New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640293 link

Starred by 1 user
Status: Fixed
Owner:
█ yzshen@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
█ roc...@chromium.org
█ tibell@chromium.org
sa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

InterfacePtr should drop pending response callbacks on error

Project Member Reported by roc...@chromium.org, Aug 23 2016 
No sense in keeping them callbacks alive if they're never going to be called.

Giving this to Yuzhu for now just so it has an owner, but anyone can feel free to take this.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e462d5b92d10e8a14312683edc920ffbadacf43f

commit e462d5b92d10e8a14312683edc920ffbadacf43f
Author: yzshen <yzshen@chromium.org>
Date: Tue Aug 23 23:19:54 2016

Mojo C++ bindings: clean up pending callbacks when connection error occurs.

The callbacks may hold on to resources. There is no need to keep them after
connection error occurs. They won't be called.

BUG= 640293 

Review-Url: https://codereview.chromium.org/2274743002
Cr-Commit-Position: refs/heads/master@{#413890}

[modify] https://crrev.com/e462d5b92d10e8a14312683edc920ffbadacf43f/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc
[modify] https://crrev.com/e462d5b92d10e8a14312683edc920ffbadacf43f/mojo/public/cpp/bindings/lib/router.cc

Comment 2 by yzshen@chromium.org, Aug 24 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment