New issue
Advanced search Search tips

Issue 640282 link

Starred by 1 user
Status: Verified
Owner:
drcrash@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 624187



Sign in to add a comment

SharedOptionsTest does not compile for Google Chrome

Project Member Reported by drcrash@chromium.org, Aug 23 2016 
What steps will reproduce the problem?
(1) Use is_chrome_branded = true as a gn arg
(2) Build the browser_tests target

What is the expected output?
* A build that compiles and links.

What do you see instead?
* Errors about prefs::kSpellCheckUseSpellingService not being defined

Please use labels and text to provide additional information.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a67c6f6ef8ba3d5130ef7cedd1dd34442bcb0e73

commit a67c6f6ef8ba3d5130ef7cedd1dd34442bcb0e73
Author: drcrash <drcrash@chromium.org>
Date: Tue Aug 23 20:10:25 2016

Include missing header files and update namespaces in browser test.

BUG= 640282 
TEST=browser tests

Review-Url: https://codereview.chromium.org/2266253004
Cr-Commit-Position: refs/heads/master@{#413824}

[modify] https://crrev.com/a67c6f6ef8ba3d5130ef7cedd1dd34442bcb0e73/chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc

Comment 2 by drcrash@chromium.org, Aug 26 2016

Blocking: 624187

Comment 3 by drcrash@chromium.org, Aug 26 2016

Status: Verified (was: Started)
►

Sign in to add a comment