New issue
Advanced search Search tips

Issue 640275 link

Starred by 1 user
Status: Fixed
Owner:
tguilbert@chromium.org
Closed: Sep 2016
Cc:
tobiasjs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused variables from StreamTexture

Project Member Reported by tguilbert@chromium.org, Aug 23 2016 
It seems like this change:
https://chromium.googlesource.com/chromium/src/+/f52b1e6228ee51bb78886d2a17155d3e2acbb0da%5E%21/#F0

Added :
  unsigned framebuffer_;
  unsigned vertex_shader_;
  unsigned fragment_shader_;
  unsigned program_;
  unsigned vertex_buffer_;
  int u_xform_location_;

And this change:
https://chromium.googlesource.com/chromium/src/+/8f2032aeb81c2a6a48ed2ed622859b59d84fbbaa%5E%21/#F5

Removes the code that uses those variables, but not the variables themselves.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af986e2dad52ea6c7594682936724a1d08179595

commit af986e2dad52ea6c7594682936724a1d08179595
Author: tguilbert <tguilbert@chromium.org>
Date: Fri Aug 26 22:41:13 2016

Remove unused variables in StreamTexure

The changes in 8f2032aeb81c2a6a48ed2ed622859b59d84fbbaa remove the code
that used the variables that were used introduced in
f52b1e6228ee51bb78886d2a17155d3e2acbb0da.

This change removes those variables and the associated code in the
destructor.

BUG= 640275 
TEST=still builds.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2264403003
Cr-Commit-Position: refs/heads/master@{#414839}

[modify] https://crrev.com/af986e2dad52ea6c7594682936724a1d08179595/gpu/ipc/service/stream_texture_android.cc
[modify] https://crrev.com/af986e2dad52ea6c7594682936724a1d08179595/gpu/ipc/service/stream_texture_android.h

Comment 2 by tguilbert@chromium.org, Sep 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment