New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640269 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

We shouldn't fail on profile changes in GpuVideoDecoder.

Project Member Reported by dalecur...@chromium.org, Aug 23 2016

Issue description

On Android the profile is not actually known with accuracy and other platforms don't seem to care. This is breaking some clients.

Internal only:
https://groups.google.com/a/google.com/d/msg/videostack-eng/7OKz-C4fMh4/gPDywJn0AAAJ
http://buganizer/30372005
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bd54ab36da9eb69239bfc95ee5e0e81ea3c42c0

commit 3bd54ab36da9eb69239bfc95ee5e0e81ea3c42c0
Author: dalecurtis <dalecurtis@chromium.org>
Date: Wed Aug 24 22:04:18 2016

Don't fail on profile changes in GpuVideoDecoder.

This restriction is artificial; or at least I can't make it fail
when the profile changes. The hardware decoders I've tried (Android,
Windows, Mac) don't seem to care if the profile actually changes.

In fact, MSE has always lied about the h264 profile (!), it always
specifies H264PROFILE_MAIN regardless of the actual profile. The
only parser sending this information correctly is the TS parser
used by Chromecast -- which then hits this check.

If the profile is actually unsupported we will still fail during
the check of SupportedProfiles.

BUG= 640269 
TEST=http://storage.googleapis.com/dalecurtis/mse_profile_change.html

Review-Url: https://codereview.chromium.org/2273793002
Cr-Commit-Position: refs/heads/master@{#414164}

[modify] https://crrev.com/3bd54ab36da9eb69239bfc95ee5e0e81ea3c42c0/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/3bd54ab36da9eb69239bfc95ee5e0e81ea3c42c0/media/filters/h264_parser.cc
[modify] https://crrev.com/3bd54ab36da9eb69239bfc95ee5e0e81ea3c42c0/media/filters/h264_parser.h
[modify] https://crrev.com/3bd54ab36da9eb69239bfc95ee5e0e81ea3c42c0/media/formats/mp2t/es_parser_h264.cc
[modify] https://crrev.com/3bd54ab36da9eb69239bfc95ee5e0e81ea3c42c0/media/formats/mp4/box_definitions.cc

Labels: -M-53 M-54
Status: Fixed (was: Started)
Don't think any clients will use this prior to M54, so not merging to M53.

Sign in to add a comment