DevTools: highlight non-page execution context |
||
Issue descriptionDue to the regressions around execution context switching, we need to communicate to the user. Pink background when execution context is not a page (when it probably should be). Before and after screenshots attached. We'll want to get this in ASAP. Beta is going to stable in 2 weeks and we need to merge this before cutoff.
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2080e2379d7b4f81f63d129491e4795187f09c7 commit a2080e2379d7b4f81f63d129491e4795187f09c7 Author: einbinder <einbinder@chromium.org> Date: Tue Sep 13 03:28:43 2016 DevTools: Warn when non-top context is selected. BUG= 640268 Review-Url: https://codereview.chromium.org/2270633003 Cr-Commit-Position: refs/heads/master@{#418159} [modify] https://crrev.com/a2080e2379d7b4f81f63d129491e4795187f09c7/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js [modify] https://crrev.com/a2080e2379d7b4f81f63d129491e4795187f09c7/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4203f3c99cd77cf9744b0983451d5b20fe4fb3d commit a4203f3c99cd77cf9744b0983451d5b20fe4fb3d Author: einbinder <einbinder@chromium.org> Date: Tue Oct 04 17:46:29 2016 DevTools: Update ExecutionContext warning on external changes BUG= 640268 Review-Url: https://codereview.chromium.org/2385383002 Cr-Commit-Position: refs/heads/master@{#422853} [modify] https://crrev.com/a4203f3c99cd77cf9744b0983451d5b20fe4fb3d/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
,
Dec 14 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by paulir...@chromium.org
, Aug 23 2016Basic CSS i used for the above: span.toolbar-select-container.toolbar-item { background: pink; padding: 0 5px 0 0; } span.toolbar-select-container.toolbar-item select.toolbar-item { padding: 0 15px 0 0; }