Missing Opt-in IME menu on shelf on lock screen |
|||||||
Issue descriptionChrome Version: 54.0.2831.0/8731.0.0 samus Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: 1) Enable the flag "Enable opt-in IME menu" in about://flags page. 2) Open "language and input" settings page, check the box with label "Show input options in the shelf". 3) Lock the screen Expected Result: To show IME menu on shelf Actual Result: IME menu falls back in status tray as before How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible. Would be better if same applied on lock screen too
,
Aug 29 2016
,
Aug 29 2016
Still repro in M55-8749 clapper ;
,
Aug 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47a06020c728d53c5f3c900234f7b6def397816a commit 47a06020c728d53c5f3c900234f7b6def397816a Author: azurewei <azurewei@chromium.org> Date: Mon Aug 29 09:21:00 2016 The opt-in IME menu was implemented with panel in shelf, which could not show in lock screen. Thus, the menu changed back the system menu. Since now the opt-in IME menu is created with native views on tray, we don't need to change back to system menu in lock screen. When switching users, the opt-in IME menu could not get preferences change event to update the menu activation state. This cl also fix this issue by saving the state by profile in InputMethodManager and sending the event of switching active user. BUG= 640266 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2274013003 Cr-Commit-Position: refs/heads/master@{#414988} [modify] https://crrev.com/47a06020c728d53c5f3c900234f7b6def397816a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc [modify] https://crrev.com/47a06020c728d53c5f3c900234f7b6def397816a/chrome/browser/chromeos/input_method/input_method_manager_impl.h [modify] https://crrev.com/47a06020c728d53c5f3c900234f7b6def397816a/chrome/browser/chromeos/input_method/mock_input_method_manager.cc [modify] https://crrev.com/47a06020c728d53c5f3c900234f7b6def397816a/chrome/browser/chromeos/input_method/mock_input_method_manager.h [modify] https://crrev.com/47a06020c728d53c5f3c900234f7b6def397816a/chrome/browser/chromeos/login/session/user_session_manager.cc [modify] https://crrev.com/47a06020c728d53c5f3c900234f7b6def397816a/ui/base/ime/chromeos/input_method_manager.h
,
Aug 30 2016
,
Aug 30 2016
,
Aug 30 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb commit c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb Author: azurewei <azurewei@chromium.org> Date: Tue Aug 30 08:59:35 2016 The opt-in IME menu was implemented with panel in shelf, which could not show in lock screen. Thus, the menu changed back the system menu. Since now the opt-in IME menu is created with native views on tray, we don't need to change back to system menu in lock screen. When switching users, the opt-in IME menu could not get preferences change event to update the menu activation state. This cl also fix this issue by saving the state by profile in InputMethodManager and sending the event of switching active user. TBR=shuchen@chromium.org NOPRESUBMIT=true NOTRY=true BUG= 640266 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2274013003 Cr-Commit-Position: refs/heads/master@{#414988} (cherry picked from commit 47a06020c728d53c5f3c900234f7b6def397816a) Review-Url: https://codereview.chromium.org/2296653002 Cr-Commit-Position: refs/branch-heads/2840@{#33} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/input_method/input_method_manager_impl.cc [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/input_method/input_method_manager_impl.h [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/input_method/mock_input_method_manager.cc [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/input_method/mock_input_method_manager.h [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/login/session/user_session_manager.cc [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/ui/base/ime/chromeos/input_method_manager.h
,
Sep 2 2016
Verified in M55-8755 clapper
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb commit c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb Author: azurewei <azurewei@chromium.org> Date: Tue Aug 30 08:59:35 2016 The opt-in IME menu was implemented with panel in shelf, which could not show in lock screen. Thus, the menu changed back the system menu. Since now the opt-in IME menu is created with native views on tray, we don't need to change back to system menu in lock screen. When switching users, the opt-in IME menu could not get preferences change event to update the menu activation state. This cl also fix this issue by saving the state by profile in InputMethodManager and sending the event of switching active user. TBR=shuchen@chromium.org NOPRESUBMIT=true NOTRY=true BUG= 640266 TEST=Verified on local build. Review-Url: https://codereview.chromium.org/2274013003 Cr-Commit-Position: refs/heads/master@{#414988} (cherry picked from commit 47a06020c728d53c5f3c900234f7b6def397816a) Review-Url: https://codereview.chromium.org/2296653002 Cr-Commit-Position: refs/branch-heads/2840@{#33} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/input_method/input_method_manager_impl.cc [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/input_method/input_method_manager_impl.h [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/input_method/mock_input_method_manager.cc [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/input_method/mock_input_method_manager.h [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/chrome/browser/chromeos/login/session/user_session_manager.cc [modify] https://crrev.com/c384b4e5c3fe954eedb050ee07fea3fe3e7f04fb/ui/base/ime/chromeos/input_method_manager.h |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by azurewei@chromium.org
, Aug 24 2016Status: Assigned (was: Untriaged)