New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640264 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Sep 2016
Cc:
wangxianzhu@chromium.org
chrishtr@chromium.org
█ wkorman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 2
Type: Bug

Blocking:
issue 598051



Sign in to add a comment

SVG filters not fully rendered with rtree patch.

Project Member Reported by wkorman@chromium.org, Aug 23 2016 
Breakout from  http://crbug.com/598051  --

css3/filters/effect-reference-hidpi.html looks like it is another SVG specific failure re: SVG filters. See expectations at:

https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/84522/layout-test-results/results.html

Likely visual rect related.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e465f9c7e83038547530b26bd26c432726a11020

commit e465f9c7e83038547530b26bd26c432726a11020
Author: pdr <pdr@chromium.org>
Date: Tue Aug 30 18:27:54 2016

Add new filter repaint test for turbulence, rebaseline existing test

This patch adds a new (currently failing) filter repaint test to show
how we improperly repaint turbulence filters. In addition, the existing
test for 640264 has been unskipped and rebaselined with a failing
result. These two changes should help catch progressions in the future.

BUG= 598051 , 640264 

Review-Url: https://codereview.chromium.org/2294633002
Cr-Commit-Position: refs/heads/master@{#415363}

[modify] https://crrev.com/e465f9c7e83038547530b26bd26c432726a11020/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/e465f9c7e83038547530b26bd26c432726a11020/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-turbulence-expected.png
[add] https://crrev.com/e465f9c7e83038547530b26bd26c432726a11020/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-turbulence-expected.txt
[add] https://crrev.com/e465f9c7e83038547530b26bd26c432726a11020/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-turbulence.html
[modify] https://crrev.com/e465f9c7e83038547530b26bd26c432726a11020/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-hidpi-expected.png

Comment 3 by pdr@chromium.org, Sep 1 2016

Cc: wangxianzhu@chromium.org
The new test added was reverted in https://crrev.com/ed9f590e796f4da44df280418d4eb3360def9486 due to underinvalidation differences between dcheck-enabled and release configuration differences on the bots.

WangXianzhu looked into this and is going to try to make underinvalidation enabled in release.

Goal is to re-add the test if that lands.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/873f27d84aaf55a3ee7ccfb0583639464efaf7bf

commit 873f27d84aaf55a3ee7ccfb0583639464efaf7bf
Author: pdr <pdr@chromium.org>
Date: Tue Sep 13 20:11:45 2016

Add new filter repaint tests for underinvalidation

This patch adds two new (currently failing) filter repaint tests to show
how we improperly repaint turbulence and image filters. These two tests
should help catch progressions in the future.

BUG= 598051 , 640264 

Review-Url: https://codereview.chromium.org/2305023003
Cr-Commit-Position: refs/heads/master@{#418347}

[modify] https://crrev.com/873f27d84aaf55a3ee7ccfb0583639464efaf7bf/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/873f27d84aaf55a3ee7ccfb0583639464efaf7bf/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-feimage-expected.png
[add] https://crrev.com/873f27d84aaf55a3ee7ccfb0583639464efaf7bf/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-feimage-expected.txt
[add] https://crrev.com/873f27d84aaf55a3ee7ccfb0583639464efaf7bf/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-feimage.html
[add] https://crrev.com/873f27d84aaf55a3ee7ccfb0583639464efaf7bf/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-turbulence-expected.png
[add] https://crrev.com/873f27d84aaf55a3ee7ccfb0583639464efaf7bf/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-turbulence-expected.txt
[add] https://crrev.com/873f27d84aaf55a3ee7ccfb0583639464efaf7bf/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-turbulence.html
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7

commit dfd9a7c5ba710ee862117267ac6c9ba343bc94f7
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Tue Sep 13 21:21:17 2016

Auto-rebaseline for r418347

https://chromium.googlesource.com/chromium/src/+/873f27d84

BUG= 640264 
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2337303002 .

Cr-Commit-Position: refs/heads/master@{#418373}

[modify] https://crrev.com/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7/third_party/WebKit/LayoutTests/platform/android/css3/filters/filter-repaint-feimage-expected.png
[rename] https://crrev.com/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7/third_party/WebKit/LayoutTests/platform/android/css3/filters/filter-repaint-turbulence-expected.png
[add] https://crrev.com/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-feimage-expected.png
[add] https://crrev.com/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-turbulence-expected.png
[add] https://crrev.com/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7/third_party/WebKit/LayoutTests/platform/mac/css3/filters/filter-repaint-feimage-expected.png
[add] https://crrev.com/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7/third_party/WebKit/LayoutTests/platform/mac/css3/filters/filter-repaint-turbulence-expected.png
[add] https://crrev.com/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7/third_party/WebKit/LayoutTests/platform/win/css3/filters/filter-repaint-feimage-expected.png
[add] https://crrev.com/dfd9a7c5ba710ee862117267ac6c9ba343bc94f7/third_party/WebKit/LayoutTests/platform/win/css3/filters/filter-repaint-turbulence-expected.png

Comment 6 by pdr@chromium.org, Sep 13 2016

Cc: chrishtr@chromium.org
Owner: ----
Status: Available (was: Assigned)
Marking as available for now. I hope we can get to this in Q4.

Comment 7 by chrishtr@chromium.org, Sep 13 2016 

This is a known rtree regression, correct?

Comment 8 by pdr@chromium.org, Sep 13 2016 

This is technically a regression but the rtree patch just exposed existing issues.  https://crbug.com/642035  has some additional data and I think fixing it will fix this bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbeebf2905898067b4def80b945aacabe9d413e9

commit fbeebf2905898067b4def80b945aacabe9d413e9
Author: fs <fs@opera.com>
Date: Thu Sep 22 09:34:15 2016

Harmonize FilterEffect::mapRect and mapPaintRect

This CL terminates the FilterEffect::determineAbsolutePaintRect codepath,
replacing the last user (SVGFilterPainter) with mapRect().
A new structure for FilterEffect::mapRect is introduced (taking some
hints from the SkImageFilter implementation), where mapRect is the entry-
point (replacing mapRectRecursive), which in turn calls: 1) mapInputs,
2) mapEffect and 3) applyBounds. The last simply applies any clip bounds
set on the effect, while also adjusting for affectsTransparentPixels().
mapInputs() computes the contribution from inputs to the current effect,
while mapEffect() applies the contribution from the current effect
itself. The notion of forward/reverse is not retained since only forward
mapping is used.

BUG= 642035 ,  640264 ,  611674 ,  600430 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2341923002
Cr-Commit-Position: refs/heads/master@{#420293}

[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-1-expected.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-1-expected.txt
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-1.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-2-expected.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-2-expected.txt
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-2.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-3-expected.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-3-expected.txt
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-3.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-4-expected.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-4-expected.txt
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-4.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-5-expected.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-5-expected.txt
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-5.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-6-expected.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-6-expected.txt
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-composite-6.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-displacement-expected.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-displacement-expected.txt
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-displacement.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-gaussianblur-expected.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-gaussianblur-xonly-expected.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-gaussianblur-xonly.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-gaussianblur-yonly-expected.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-gaussianblur-yonly.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-gaussianblur.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-lighting-expected.html
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-lighting-expected.txt
[add] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-lighting.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-merge-expected.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-merge-expected.txt
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-merge.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-morphology-expected.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-morphology-xonly-expected.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-morphology-xonly.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-morphology-yonly-expected.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-morphology-yonly.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-morphology.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-offset-expected.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-offset-expected.txt
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-offset.html
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-feimage-expected.png
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/platform/linux/css3/filters/filter-repaint-turbulence-expected.png
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-hidpi-expected.png
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/platform/mac/css3/filters/filter-repaint-feimage-expected.png
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/platform/mac/css3/filters/filter-repaint-turbulence-expected.png
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-hidpi-expected.png
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/platform/win/css3/filters/filter-repaint-feimage-expected.png
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/LayoutTests/platform/win/css3/filters/filter-repaint-turbulence-expected.png
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEComposite.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FELighting.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FEOffset.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FETile.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FETile.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/FilterOperation.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.h
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.cpp
[modify] https://crrev.com/fbeebf2905898067b4def80b945aacabe9d413e9/third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h

Comment 10 by f...@opera.com, Sep 23 2016

Owner: f...@opera.com
Status: Fixed (was: Available)
#9 fixed all the tests associated with this bug, so does indeed seem the statement in #8 was correct =). Resolving.

Comment 11 by pdr@chromium.org, Sep 23 2016 

Thank you! What a great cleanup.
►

Sign in to add a comment