New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640260 link

Starred by 2 users
Status: Fixed
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

add page load histograms to track parser blocking script execution time

Project Member Reported by bmcquade@chromium.org, Aug 23 2016 
We already track parser blocking script load time. We should also track parser blocking script execution time. We have a few use cases:
* allows us to understand % of parse time blocked on script exec time, to better understand whether script exec time is a significant contributor to page load time
* having this would have helped us to catch a regression that took hours of time to identify the root cause of (crbug.com/608424)
* there is a desire to understand how much time scripts inserted via doc.write spend executing, in addition to loading
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473

commit cb637fa03a98d0f764cfcfac6fae5cebc4c7c473
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Sep 08 17:46:29 2016

Instrument parser blocking script execution time.

We already track parser blocking script load time. This patch
adds support for tracking parser blocking script execution time.

We have a few use cases for this:
* allows us to understand % of parse time blocked on script exec
  time, to better understand whether script exec time is a
  significant contributor to page load time
* having this would have helped us to catch a regression that took
  hours of time to identify the root cause of (crbug.com/608424)
* there is a desire to understand how much time scripts inserted
  via doc.write spend executing, in addition to loading

BUG= 640260 

Review-Url: https://codereview.chromium.org/2238543002
Cr-Commit-Position: refs/heads/master@{#417330}

[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/common/page_load_metrics/page_load_metrics_messages.h
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/common/page_load_metrics/page_load_timing.h
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/core/dom/DocumentParserTiming.h
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/core/dom/ScriptLoader.h
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/core/dom/ScriptRunner.h
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/core/timing/PerformanceTiming.h
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/Source/web/WebPerformance.cpp
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/third_party/WebKit/public/web/WebPerformance.h
[modify] https://crrev.com/cb637fa03a98d0f764cfcfac6fae5cebc4c7c473/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/612a4b664c1589e12d2d12e35044c68224c63851

commit 612a4b664c1589e12d2d12e35044c68224c63851
Author: bmcquade <bmcquade@chromium.org>
Date: Mon Sep 19 21:31:13 2016

Add histograms for script execution time for doc write observer

There has been a desire to better understand the breakdown of performance
impact as a result of the doc.write intervention. We currently track
script load time duration for the intervention. This change allows us
to also track script execution time duration for the intervention.

BUG= 640260 

Review-Url: https://codereview.chromium.org/2346813002
Cr-Commit-Position: refs/heads/master@{#419557}

[modify] https://crrev.com/612a4b664c1589e12d2d12e35044c68224c63851/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
[modify] https://crrev.com/612a4b664c1589e12d2d12e35044c68224c63851/tools/metrics/histograms/histograms.xml

Comment 3 by bmcquade@chromium.org, Sep 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment