New issue
Advanced search Search tips

Issue 640254 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug


Sign in to add a comment

Roll clang again

Project Member Reported by thakis@chromium.org, Aug 23 2016

Issue description

r278861 fixes base class debug info (amccarth is checking that it doesn't regress link time, so let's wait for that)

Several changes to the style plugin to always turn on checks that are currently always turned on via flags (we can then remove the flags after the roll) (make sure to build past #413772)

r279116 makes -Wextern-initializer less noisy, so that we can stop suppressing it in clang-cl builds again

r279531 adds support for /source-charset:utf-8

https://reviews.llvm.org/D23805 will fix /Brepro


Nothing super urgent yet, but already a bunch of nice-to-haves.
 

Comment 1 by thakis@chromium.org, Aug 25 2016

Blocking: 636091
r279765 omits column info by default (which is good – fixes  bug 636091 ) but we'll likely want to pass -gcolumn-info on the lkgr clusterfuzz bots to turn it back on there when we roll.

Comment 2 by h...@chromium.org, Aug 26 2016

need to remember to address the flags todo from https://codereview.chromium.org/2281963002/

Comment 3 by h...@chromium.org, Aug 26 2016

Blocking: 636109

Comment 4 by thakis@chromium.org, Aug 30 2016

Giving it a go here: https://codereview.chromium.org/2292173002/
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a033f395bf2547cf4764f77cc9c86d08f3e22c23

commit a033f395bf2547cf4764f77cc9c86d08f3e22c23
Author: thakis <thakis@chromium.org>
Date: Wed Aug 31 05:16:14 2016

Roll clang 278861:280106.

* win: Members of base classes now should show up in debugger.
* win: Debugger shouldn't show funny highlights anymore due to
  debug info no longer including column information.  (we still
  force this on if sanitizers are used, mostly for clusterfuzz.
  maybe we want to make this toggleable independent of sanitizers
  at some point)
* win: -Wextern-initializer no longer warns on midl-generated code
* win: clang-cl now accepts /source-encoding:utf-8 and friends
  (utf-8 was the source enconding in clang-cl before already, but
  now we don't warn on an explicit flag requesting this)
* all platforms: Three plugin checks are now on-by-default,
  remove flags for these (see
    https://codereview.chromium.org/2267713003
    https://codereview.chromium.org/2268203002
    https://codereview.chromium.org/2265093002
  )
* win: clang-cl's /Brepro now does what it's supposed to do
* win: clang-cl now emits absolute paths in diagnostics, by
  popular request.

Ran `tools/clang/scripts/upload_revision.py 280106`.

BUG= 640254 , 637456 , 636109 , 636091 , 636099 

Review-Url: https://codereview.chromium.org/2292173002
Cr-Commit-Position: refs/heads/master@{#415563}

[modify] https://crrev.com/a033f395bf2547cf4764f77cc9c86d08f3e22c23/build/config/clang/BUILD.gn
[modify] https://crrev.com/a033f395bf2547cf4764f77cc9c86d08f3e22c23/build/config/compiler/BUILD.gn
[modify] https://crrev.com/a033f395bf2547cf4764f77cc9c86d08f3e22c23/build/config/sanitizers/BUILD.gn
[modify] https://crrev.com/a033f395bf2547cf4764f77cc9c86d08f3e22c23/build/config/win/BUILD.gn
[modify] https://crrev.com/a033f395bf2547cf4764f77cc9c86d08f3e22c23/tools/clang/scripts/update.py

Status: Fixed (was: Untriaged)

Sign in to add a comment