New issue
Advanced search Search tips

Issue 640248 link

Starred by 3 users
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Restrict the AlertDialog presubmit warning to src/chrome

Project Member Reported by hush@chromium.org, Aug 23 2016 
This presubmit warning 

"""
Avoid android.app.AlertDialog; if possible, use
android.support.v7.app.AlertDialog instead, which has a Material look on all
devices. (Some parts of the codebase can’t depend on the support library, in
which case android.app.AlertDialog is the only option)
"""

should be restricted to chrome/ because other parts of the code base cannot depend on the support library.

Comment 1 by wychen@chromium.org, Oct 5 2016 

Besides chrome/, blimp/ and remoting/ also already have android.support.v7.app.AlertDialog usage.

https://codereview.chromium.org/2394753002/ suppresses it in content/ as a conservative start.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fc653a91c70e0a2357e83fdc16f6cc9c80fb23f

commit 9fc653a91c70e0a2357e83fdc16f6cc9c80fb23f
Author: wychen <wychen@chromium.org>
Date: Fri Oct 07 19:12:01 2016

Suppress the AlertDialog presubmit warning when not useful

This warning is only useful in chrome/, blimp/, and remoting/, which can
depend on the support library.

On the other hand, content layer cannot depend on the support library.
Therefore, all the directories containing Java packages that could be
imported by content layer are suppressed.

BUG= 640248 

Review-Url: https://codereview.chromium.org/2394753002
Cr-Commit-Position: refs/heads/master@{#423922}

[modify] https://crrev.com/9fc653a91c70e0a2357e83fdc16f6cc9c80fb23f/tools/android/checkstyle/suppressions.xml

Comment 3 by wychen@chromium.org, Oct 7 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment