Issue metadata
Sign in to add a comment
|
[Regression] On Locked state screen, system tray focus is not drawn |
||||||||||||||||||||||||
Issue descriptionVersion: 54.0.2837.0 What steps will reproduce the problem? (1) Locked the screen using Search + L or ctrl+shift+L (2) keep pressing tab, system tray is not focusable Here is the console log: [30233:30233:0823/095315:ERROR:PlatformKeyboardEvent.cpp(93)] Not implemented reached in static bool blink::PlatformKeyboardEvent::currentCapsLockState() The previous code point is here: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/ui/webui_login_view.cc?dr=CSs&q=takefocus+webui&sq=package:chromium&l=434 Not sure where it is broken. cc some people for any clues.
,
Aug 24 2016
bisects: https://chromium.googlesource.com/chromium/src/+log/9e8c5f4e30270447969f04bfe4d676b6d94f25b9..f2b9160d19a992d7132d9a77014931b2fc230089 Suspecting CL: https://codereview.chromium.org/2147143002 Assigned to yiyix@, if you have time. Otherwise, I can also take a look into it.
,
Aug 24 2016
Note that the tray does receive focus (may be confirmed by pressing ENTER); it's just that the blue focus rectangle isn't drawn.
,
Aug 24 2016
I tried to revert to the CL before my change, and it works fine. My CL has broken this part.
,
Aug 24 2016
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b836eb96a445e7ec886b7acac2bf3f87eefc56b commit 5b836eb96a445e7ec886b7acac2bf3f87eefc56b Author: yiyix <yiyix@chromium.org> Date: Wed Aug 24 19:00:58 2016 Fix system tray focus on locked state screen When TrayBackgroundView has overridden the OnPaint method from its parent class, it did not neither implement a new OnPaintFocus method nor calling the one the parent class. So focus selection stopped working. TEST=MANUAL - Turn on Lock Screen by pressing ctrl+shift+L, then change focus by pressing "tab". Check if system tray can be focused. Repeat this test by using ash-md=experimental and ash-md=normal. BUG= 640246 Review-Url: https://codereview.chromium.org/2271763005 Cr-Commit-Position: refs/heads/master@{#414117} [modify] https://crrev.com/5b836eb96a445e7ec886b7acac2bf3f87eefc56b/ash/common/system/tray/tray_background_view.cc
,
Aug 24 2016
,
Aug 29 2016
,
Aug 29 2016
verified on 54.0.2840.3 / 8743.3.0 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by abodenha@chromium.org
, Aug 23 2016Owner: warx@chromium.org
Status: Assigned (was: Untriaged)