PanelLayoutManager may attempt to position callout widgets on different displays |
||||
Issue descriptionI recently introduced a crash in PanelLayoutManager. See the analysis here: https://bugs.chromium.org/p/chromium/issues/detail?id=636113#c12 . In order for the crash to happen PanelLayoutManager is attempting to position the callout widget on a different display. This seems like a bug in PanelLayoutManager, and most likely it's callout calculations. A fix in the works for a crash, but it would be good to understand why PanelLayoutManager is trying to position the callout widget on a different display.
,
Aug 23 2016
+flackr@ who seems to have worked on callout. My guess is that shelf might have been hidden (could be set to auto hide, or could be due to fullscreen/immersive) in which case, the screen bounds for these widget docan be outside of the display.
,
Aug 23 2016
ash::PanelCalloutWidget::SetAlignment is called from ash::PanelLayoutManager::Relayout before we've actually determined where the windows (and thus the callouts) will be. Perhaps we can defer updating the callout widget bounds for their new orientation until ash::PanelLayoutManager::UpdateCallouts which happens later in Relayout.
,
Aug 25 2016
,
Sep 1 2016
I confirmed that the callout widget bounds becomes outside of the display when shelf is hidden, so this is WAI. |
||||
►
Sign in to add a comment |
||||
Comment 1 by steve...@chromium.org
, Aug 23 2016Owner: osh...@chromium.org