New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640233 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in SkGradientShaderBase::SkGradientShaderBase

Project Member Reported by ClusterFuzz, Aug 23 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5978838863708160

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkGradientShaderBase::SkGradientShaderBase
  SkTwoPointConicalGradient::SkTwoPointConicalGradient
  SkGradientShader::MakeTwoPointConical
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=413208:413324

Minimized Testcase (0.61 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97QpOf6HdqPNxqOqPjwijBL0a0b4KI3BzWM2Wd5vwKbSPFs27xOhXRPAcZR7ofb81ZPzN0z5efxmcZC0Zp3cbP3syAJ0tfkHZVlHU_OJJuUJp9cJuhp-m4inNUdtwQvvhekr5dhskyTa-RgE-9h74OfBn_GWw?testcase_id=5978838863708160

Issue manually filed by: inferno

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: fmenozzi@google.com
Labels: Pri-1
Owner: reed@chromium.org
Status: Assigned (was: Untriaged)
Author: fmenozzi
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/e9fd0f8eafb68ff92aab257e9a7429eb29047327
Time: Fri Aug 19 14:50:57 2016
Lines 874 of file SkGradientShader.cpp which potentially caused crash are changed in this cl (frame #0, "SkGradientShader::MakeTwoPointConical").
Minimum distance from crash line to modified line: 0. (file: SkGradientShader.cpp, crashed on: 873, modified: 873).

Suspected Project: chromium-skia
Suspected Component: Internals>Skia
Components: Internals>Skia
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 24 2016

Labels: M-54
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 24 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by ClusterFuzz, Aug 26 2016

Labels: Stability-Memory-AddressSanitizer
Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6507769102598144

Fuzzer: inferno_twister
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x60200005d85c
Crash State:
  SkGradientShader::MakeTwoPointConical
  blink::Gradient::createShader
  blink::Gradient::applyToPaint
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=413455:413548

Minimized Testcase (0.68 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97wWEvhXqO-y7Z_CsL53sDprQ3U3QEWm032WnF4RaK-Nzr-JxfjqXFdtDzRMLAHbScqNW8rC02WYfndy7PjqsDQkDi6g6dRNarT6AV-QfgLquOB1sUdUJ4OclPTvQE4x_b1gCwsvzWY64VT8Mg46TihZSOCWQ?testcase_id=6507769102598144

Issue manually filed by: inferno

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 1 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Friendly ping, this is currently a Beta-blocker and needs to get fixed and merged as soon as feasible, as M54 is going to beta this Thursday 9/8

Project Member

Comment 8 by sheriffbot@chromium.org, Sep 7 2016

reed: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Moving to ReleaseBlock-Stable to keep track of this for M54
Project Member

Comment 10 by ClusterFuzz, Sep 14 2016

ClusterFuzz has detected this issue as fixed in range 418377:418438.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5978838863708160

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkGradientShaderBase::SkGradientShaderBase
  SkTwoPointConicalGradient::SkTwoPointConicalGradient
  SkGradientShader::MakeTwoPointConical
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=413208:413324
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=418377:418438

Minimized Testcase (0.61 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97QpOf6HdqPNxqOqPjwijBL0a0b4KI3BzWM2Wd5vwKbSPFs27xOhXRPAcZR7ofb81ZPzN0z5efxmcZC0Zp3cbP3syAJ0tfkHZVlHU_OJJuUJp9cJuhp-m4inNUdtwQvvhekr5dhskyTa-RgE-9h74OfBn_GWw?testcase_id=5978838863708160

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Cc: hcm@chromium.org
Owner: tomhud...@chromium.org
Project Member

Comment 12 by ClusterFuzz, Sep 17 2016

ClusterFuzz has detected this issue as fixed in range 419286:419365.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6507769102598144

Fuzzer: inferno_twister
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x60200005d85c
Crash State:
  SkGradientShader::MakeTwoPointConical
  blink::Gradient::createShader
  blink::Gradient::applyToPaint
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=413455:413548
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=419286:419365

Minimized Testcase (0.68 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97wWEvhXqO-y7Z_CsL53sDprQ3U3QEWm032WnF4RaK-Nzr-JxfjqXFdtDzRMLAHbScqNW8rC02WYfndy7PjqsDQkDi6g6dRNarT6AV-QfgLquOB1sUdUJ4OclPTvQE4x_b1gCwsvzWY64VT8Mg46TihZSOCWQ?testcase_id=6507769102598144

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Sep 17 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Sep 18 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Looks like a dupe of 647481
Project Member

Comment 16 by sheriffbot@chromium.org, Dec 25 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment