New issue
Advanced search Search tips

Issue 640232 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

IndexedDBBackingStore::RecordCorruptionInfo() should write to temp and rename.

Project Member Reported by cmumford@chromium.org, Aug 23 2016

Issue description

IndexedDBBackingStore::ReadCorruptionInfo() sometimes encounters empty files. These could be created by some other program, but also caused by an interruption in IndexedDBBackingStore::RecordCorruptionInfo(). Should modify RecordCorruptionInfo() to write to temp file and rename to fix this.
 
base::ImportantFileWriter is your friend.
Owner: ----
Status: Available (was: Assigned)

Comment 3 by dmu...@chromium.org, May 15 2018

Labels: Hotlist-GoodFirstBug
can I handle this issue? I'm novice on Chromium contribution, so it will be great experience for me

Comment 5 by andreasbutler@google.com, Jan 17 (6 days ago)

Owner: andreasbutler@google.com
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid, Today (7 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/342698dc84f1e3f19abad8efcc2fe379a1208f3c

commit 342698dc84f1e3f19abad8efcc2fe379a1208f3c
Author: Andreas Butler <andreasbutler@google.com>
Date: Thu Jan 24 00:43:08 2019

[IndexedDB]: Modify RecordCorruptionInfo to use ImportantFileWriter

As per crbug640232, RecordCorruptionInfo's method of writing a
corruption report to a file is modified from making a file and then
writing to it to writing it atomically using ImportantFileWriter's
WriteFileAtomically method to avoid issues involving interruption of
the file write between file creation and actual writing of the record.

Bug:  640232 
Change-Id: I69aad54da0c341528dbcf46ebf5a2b08cc3270f6
Reviewed-on: https://chromium-review.googlesource.com/c/1419261
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Andreas Butler <andreasbutler@google.com>
Cr-Commit-Position: refs/heads/master@{#625431}

Comment 7 by andreasbutler@google.com, Today (7 hours ago)

Status: Fixed (was: Assigned)

Sign in to add a comment