New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

[Regression] Window controls don't work for V1 apps

Project Member Reported by varkha@chromium.org, Aug 23 2016 
Version: 54.0.2838.0
OS: Chrome OS

What steps will reproduce the problem?
(1) Open any site
(2) Menu -> More Tools -> Add to shelf and check "Open as window"
(3) Click the added shelf item
(4) Try to close it clicking the [x] button

What is the expected output?
Window closes

What do you see instead?
Nothing, also no hover effect on window controls.

Please use labels and text to provide additional information.
This is a regression. Locally reverting https://codereview.chromium.org/2262563002/ (55e6cc560a8e152d26f1b69e0929c53681eeacd7) seems to fix this.

Comment 1 by bsep@chromium.org, Aug 23 2016 

Seems like the kind of thing I would have broken, thanks for the report. I'll handle it.

Comment 2 by bsep@chromium.org, Aug 23 2016

Status: Fixed (was: Assigned)
Reverted the offending patch https://codereview.chromium.org/2273863002/

Comment 3 by bsep@chromium.org, Aug 24 2016

Cc: abodenha@chromium.org durga.behera@chromium.org jen...@chromium.org rookrishna@chromium.org songsuk@chromium.org ajha@chromium.org bsep@chromium.org kavvaru@chromium.org dhadd...@chromium.org harpreet@chromium.org osh...@chromium.org
 Issue 640482  has been merged into this issue.

Comment 4 by osh...@chromium.org, Aug 25 2016

Cc: steve...@chromium.org
 Issue 641054  has been merged into this issue.

Comment 5 by abodenha@chromium.org, Aug 25 2016

Cc: xiy...@chromium.org azurewei@chromium.org xiangye@chromium.org xiulingw@chromium.org shuchen@chromium.org wuyingbing@chromium.org
 Issue 640858  has been merged into this issue.

Comment 6 by osh...@chromium.org, Aug 26 2016

Cc: skuhne@chromium.org zelidrag@chromium.org
 Issue 641371  has been merged into this issue.

Comment 7 by abod...@chromium.org, Aug 26 2016 

 Issue 641196  has been merged into this issue.

Comment 8 by canhtan...@gmail.com, Aug 26 2016 

defendants

---------- Thư đã chuyển tiếp ----------
Từ: "abode… via monorail" <monorail+v2.913212481@chromium.org>
Ngày: 26-08-2016 5:36
Chủ đề:  Issue 640230  in chromium: [Regression] Window controls don't work
for V1 apps
Tới: <canhtan429@gmail.com>
Cc:

xiulingw@chromium.org shuchen@chromium.org wuyingbing@chromium.org

controls don't work for V1 apps

Comment 9 by hsiangc@chromium.org, Aug 26 2016

Cc: avkodipelli@chromium.org hsiangc@chromium.org nnag...@chromium.org
issue also reproduce on Hulu, ESPN pop up window with build 8747.0.0/54.0/2837.0

Comment 10 by norvez@chromium.org, Aug 30 2016 

 Issue 642160  has been merged into this issue.

Comment 11 by abodenha@chromium.org, Sep 1 2016 

 Issue 641671  has been merged into this issue.

Comment 12 by rookrishna@chromium.org, Sep 21 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment