New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640228 link

Starred by 5 users

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 593720

Blocking:
issue 652711



Sign in to add a comment

Test Runner fails silently when trying to write command line flags to N

Project Member Reported by peconn@chromium.org, Aug 23 2016

Issue description

When running tests on Android N command line flags passed to the test runner are not passed to the device. This is due to Issue 593720.

However the test runner should not fail silently when this happens.
 
Labels: OS-Android
Status: Assigned (was: Untriaged)
I misdiagnosed this -- the issue isn't that the flags aren't pushed to the device, it's that, when the device is rooted, they're pushed to /data/local/chrome-command-line, which the APK can't read.

The short-term fix here is the script counterpart to https://bugs.chromium.org/p/chromium/issues/detail?id=593720#c18 -- push to /data/local/tmp/ instead of /data/local/ in more scenarios on N.
Labels: -Restrict-View-Google
Status: Fixed (was: Assigned)
Fix landed in https://codereview.chromium.org/2275863002/ and was manually rolled into chromium in https://codereview.chromium.org/2270313004
We're reverting this fix since it broke telemetry for some benchmarks on issue 641497. Anyway, I'll try to get this fixed soon as part of issue 593720.
Status: Assigned (was: Fixed)
Blockedon: 593720
Cc: jbudorick@chromium.org
Owner: perezju@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac9c7854255ee68b7873d3dd31c2665b075de2d1

commit ac9c7854255ee68b7873d3dd31c2665b075de2d1
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Aug 31 15:38:30 2016

Roll src/third_party/catapult/ fa2c4f219..aa7c58eb0 (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fa2c4f21907f..aa7c58eb0459

$ git log fa2c4f219..aa7c58eb0 --date=short --no-merges --format='%ad %ae %s'
2016-08-31 perezju Revert of [devil] Use /data/local/tmp for the command line on eng + userdebug builds. (patchset #2 id:20001 of https://codereview.chromium.org/2275863002/ )
2016-08-31 nednguyen Fix flakes in csv_pivot_table_output_formatter_unittest.

BUG= 640228 ,641497

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2293973003
Cr-Commit-Position: refs/heads/master@{#415641}

[modify] https://crrev.com/ac9c7854255ee68b7873d3dd31c2665b075de2d1/DEPS

Blocking: 652711
Blocking: -652711
Blocking: 652711
Cc: rnep...@chromium.org nednguyen@chromium.org aiolos@chromium.org eyaich@chromium.org perezju@chromium.org
 Issue 652711  has been merged into this issue.

Comment 11 by u...@chromium.org, Nov 21 2016

Cc: u...@chromium.org

Comment 12 by u...@chromium.org, Nov 21 2016

For some reason applying https://codereview.chromium.org/2275863002/ locally didn't work for me.
I managed to work around the command line issue by forcing /data/local/tmp in telemetry/telemetry/internal/backends/android_browser_backend_settings.py

After fixing the command line I am hitting the same issue with /data/local/chrome-trace-config.json

Benchmark runner fails with "Tracing is not started". 
I tried to redirect /data/local/chrome-trace-config.json to /data/local/tmp/chrome-trace-config.json in chrome and catapult but that is not working: chrome does not see /data/local/tmp/chrome-trace-config.json.

Juan, Ned, do you know if chrome-trace-config.json issue is being tracked and if there is a workaround?
If not I'll file a new issue.
Cc: hablich@chromium.org
I don't think this bug should be Pri=3 because it prevents us from testing on the newest Android.
Labels: -Pri-3 Pri-1
The workaround is to ensure there are no chrome config files on *neither* /data/local/tmp/ nor /data/local/ before starting the test runner.

Also bumping up Pri.
Status: Archived (was: Assigned)
Moving this over to catapult's issue tracker: https://github.com/catapult-project/catapult/issues/3112

Sign in to add a comment