New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640225 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

WebRTC's send-side bandwidth estimator incorrectly includes RTP headers in estimate

Project Member Reported by holmer@chromium.org, Aug 23 2016

Issue description

Send-side BWE incorrectly includes RTP headers in its estimate, while the recv-side BWE only includes the payload, which causes the estimate to be higher than it should be. This in turn causes us to encode at a too high bitrate, which in the end causes us to send more than the link can handle.
 

Comment 1 by holmer@chromium.org, Aug 23 2016

Corresponding webrtc bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=6247

Comment 2 by holmer@chromium.org, Aug 23 2016

Labels: Merge-Request-53
The fix for this just landed in webrtc, so it hasn't baked in Canary for a day yet.

Still, I'm requesting a merge now since I'll be on vacation the following days. Philip will help out as needed.

Comment 3 by holmer@chromium.org, Aug 23 2016

Cc: -philipel@chromium.org holmer@chromium.org
Owner: philipel@chromium.org

Comment 4 by gov...@chromium.org, Aug 23 2016

Thank you holmer@.

philipel@, please update the bug with canary result. Once it is well baked/verified and safe merge to M53, I will approve the merge. Thank you.

Comment 5 by dimu@chromium.org, Aug 24 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M53, manual review required.

Comment 6 by gov...@chromium.org, Aug 24 2016

How is the canary data looking? 
Tried it out just now and everything looks good.

Comment 8 by gov...@chromium.org, Aug 25 2016

Labels: -Merge-Review-53 Merge-Approved-53
Approving merge to M53 branch 2785 based on comment #7. Please merge ASAP or latest by 5:00 PM PT, Friday (08/26) in order to make into the desktop Stable final build cut.
CL for this merge: https://codereview.webrtc.org/2285733002/
Labels: -Merge-Approved-53 Merge-Merged-53
Per comment #10, this is already merged to M53, so removing "Merge-Approved-53" label and applying "merge-merged-53" label.
Status: Fixed (was: Assigned)

Sign in to add a comment