New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640214 link

Starred by 2 users
Status: Fixed
Owner:
xidac...@chromium.org
Closed: Sep 2016
Cc:
█ junov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

HTMLVideoElement::paintCurrentFrame drops the filter quality

Project Member Reported by xidac...@chromium.org, Aug 23 2016 
In ctx.drawImage, if the source is an HTMLVideoElement, it eventually calls  HTMLVideoElement::paintCurrentFrame() method, when this method calls webMediaPlayer()->paint(), the filterQuality is dropped and no longer used. As a result, specifying imageSmoothing quality when drawing a video doesn't work as expected.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ebd94d53de1de4631466ae8497c2515c1d0ecd7

commit 0ebd94d53de1de4631466ae8497c2515c1d0ecd7
Author: xidachen <xidachen@chromium.org>
Date: Wed Sep 07 15:47:22 2016

Pass SkPaint instead of its alpha and mode in WebMediaPlayer::paint

At this moment, the WebMediaPlayer::paint takes the alpha and SkXferMode
of the paint, and drop all the other properties of the SkPaint. We should
pass the whole SkPaint as the argument instead of passing only two of its
properties. Doing this will avoid other properties such as filter quality
gets dropped

BUG= 640214 ,  456529 
TBR=qinmin@chromium.org, esprehn@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2276033002
Cr-Commit-Position: refs/heads/master@{#416942}

[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/content/renderer/media/android/webmediaplayer_android.cc
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/content/renderer/media/android/webmediaplayer_android.h
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/content/renderer/media/html_video_element_capturer_source.cc
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/content/renderer/media/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/media/renderers/skcanvas_video_renderer.cc
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/media/renderers/skcanvas_video_renderer.h
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/media/renderers/skcanvas_video_renderer_unittest.cc
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-video-shadow-expected.png
[add] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-video-shadow-expected.txt
[add] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-video-shadow.html
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/LayoutTests/fast/canvas/canvas-composite-video.html
[add] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-video-imageSmoothingEnabled.html
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
[modify] https://crrev.com/0ebd94d53de1de4631466ae8497c2515c1d0ecd7/third_party/WebKit/public/platform/WebMediaPlayer.h

Comment 2 by xidac...@chromium.org, Sep 7 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment