Delete SvnPollerWithComparator |
||||
Issue descriptionAssigning to Brad so he can triage. $ git grep SvnPoller masters/master.client.nacl.sdk/master.cfg:multirel_poller = svn_poller_with_comparator.SvnPollerWithComparator( scripts/master/svn_poller_with_comparator.py: (...) It is polling buildspec/build/chrome-official via svn. BTW, https://build.chromium.org/p/client.nacl.sdk/waterfall is quite red.
,
Aug 23 2016
,
Aug 24 2016
Oh dear, haven't been pushing though releases for a while. Is there an equivalent git url now that triggers release builds? This was being used to ensure we got nacl sdk's of the same vintage as chrome builds.
,
Aug 24 2016
The buildspecs are now in git: https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/master/build/chrome-official/ We don't expose that subdirectory directly. Based on the other official masters, it looks like what you want is: import buildspec_utils poller = buildspec_utils.BuildspecPoller(['build/chrome-official'], svn_mode=False) c['change_source'] = [poller]
,
Dec 21 2016
This seems like it should be pretty straightforward -- the only instance of the SvnPollerWithComparator that I see anymore is in one master, and I don't see how it could possibly be useful anymore, so: https://chrome-internal-review.googlesource.com/c/313978/ https://chromium-review.googlesource.com/c/423168/
,
Dec 21 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build/+/70560770a9b81c36994293a799b18a0e2a092c12 commit 70560770a9b81c36994293a799b18a0e2a092c12 Author: Aaron Gable <agable@chromium.org> Date: Wed Dec 21 23:18:13 2016
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/3eae1165714f72471234302b52f6d12ecd3fe2df commit 3eae1165714f72471234302b52f6d12ecd3fe2df Author: Aaron Gable <agable@chromium.org> Date: Wed Dec 21 23:19:54 2016 Remove unused SvnPollerWithComparator BUG= 640211 Change-Id: Ie41e997a83e4454a36d35b2272e1d6c483b22d76 Reviewed-on: https://chromium-review.googlesource.com/423168 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [delete] https://crrev.com/be346aa5e79294bea2a7cba5ace2692b4ea59846/scripts/master/svn_poller_with_comparator.py
,
Dec 22 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mar...@chromium.org
, Aug 23 2016