New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640211 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 475320
issue 600451



Sign in to add a comment

Delete SvnPollerWithComparator

Project Member Reported by mar...@chromium.org, Aug 23 2016

Issue description

Assigning to Brad so he can triage.

$ git grep SvnPoller
masters/master.client.nacl.sdk/master.cfg:multirel_poller = svn_poller_with_comparator.SvnPollerWithComparator(
scripts/master/svn_poller_with_comparator.py: (...)

It is polling buildspec/build/chrome-official via svn.

BTW, https://build.chromium.org/p/client.nacl.sdk/waterfall is quite red.
 

Comment 1 by mar...@chromium.org, Aug 23 2016

Labels: -OS-Mac
Blocking: 600451
Oh dear, haven't been pushing though releases for a while.
Is there an equivalent git url now that triggers release builds?
This was being used to ensure we got nacl sdk's of the same vintage as chrome builds.

Comment 4 by aga...@chromium.org, Aug 24 2016

The buildspecs are now in git: https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/master/build/chrome-official/

We don't expose that subdirectory directly. Based on the other official masters, it looks like what you want is:

import buildspec_utils
poller = buildspec_utils.BuildspecPoller(['build/chrome-official'], svn_mode=False)
c['change_source'] = [poller]

Comment 5 by aga...@chromium.org, Dec 21 2016

Cc: bradnelson@chromium.org
Owner: aga...@chromium.org
Status: Started (was: Assigned)
This seems like it should be pretty straightforward -- the only instance of the SvnPollerWithComparator that I see anymore is in one master, and I don't see how it could possibly be useful anymore, so:

https://chrome-internal-review.googlesource.com/c/313978/
https://chromium-review.googlesource.com/c/423168/
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/70560770a9b81c36994293a799b18a0e2a092c12

commit 70560770a9b81c36994293a799b18a0e2a092c12
Author: Aaron Gable <agable@chromium.org>
Date: Wed Dec 21 23:18:13 2016

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3eae1165714f72471234302b52f6d12ecd3fe2df

commit 3eae1165714f72471234302b52f6d12ecd3fe2df
Author: Aaron Gable <agable@chromium.org>
Date: Wed Dec 21 23:19:54 2016

Remove unused SvnPollerWithComparator

BUG= 640211 

Change-Id: Ie41e997a83e4454a36d35b2272e1d6c483b22d76
Reviewed-on: https://chromium-review.googlesource.com/423168
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[delete] https://crrev.com/be346aa5e79294bea2a7cba5ace2692b4ea59846/scripts/master/svn_poller_with_comparator.py

Comment 8 by aga...@chromium.org, Dec 22 2016

Status: Fixed (was: Started)

Sign in to add a comment