New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640199 link

Starred by 2 users
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Aug 2016
Cc:
mahmadi@chromium.org
█ janeliulwq@google.com
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Make 'Disconnect Account' overlay in MD settings accessible through a URL

Project Member Reported by mahmadi@chromium.org, Aug 23 2016 
The 'Disconnect Account' overlay for managed accounts needs to be linked to chrome://md-settings/signOut.

This is needed by the MD user menu: when a managed user encounters an unrecoverable error and chooses to sign out to resolve it, the user will be directed to the 'Disconnect Account' dialog to confirm disconnection. See design doc here: https://docs.google.com/document/d/1jEzY44oMWenzJQUIBf1x8dkkqm2PJbYngvQzeXTMkLc/edit#bookmark=id.9a7krxlmbdyu.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bb6b2df54d7a4b3dbd76aa59d64747ad886d58f

commit 5bb6b2df54d7a4b3dbd76aa59d64747ad886d58f
Author: jianli <jianli@chromium.org>
Date: Fri Aug 26 00:24:52 2016

Revert of Settings People: Add /signOut route for Disconnect dialog. (patchset #2 id:20001 of https://codereview.chromium.org/2271843002/ )

Reason for revert:
The following browser test failed:
 CrSettingsPeoplePageTest.PeoplePage

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/32657

Original issue's description:
> Settings People: Add /signOut route for Disconnect dialog.
>
> BUG= 640199 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/54a670192c726f5762109842c0ecc958ad045256
> Cr-Commit-Position: refs/heads/master@{#414562}

TBR=michaelpg@chromium.org,tommycli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 640199 

Review-Url: https://codereview.chromium.org/2279883004
Cr-Commit-Position: refs/heads/master@{#414596}

[modify] https://crrev.com/5bb6b2df54d7a4b3dbd76aa59d64747ad886d58f/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
[modify] https://crrev.com/5bb6b2df54d7a4b3dbd76aa59d64747ad886d58f/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/5bb6b2df54d7a4b3dbd76aa59d64747ad886d58f/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/5bb6b2df54d7a4b3dbd76aa59d64747ad886d58f/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/5bb6b2df54d7a4b3dbd76aa59d64747ad886d58f/chrome/test/data/webui/settings/people_page_test.js

Comment 4 by tommycli@chromium.org, Aug 30 2016

Status: Fixed (was: Assigned)
Hope this sticks...
►

Sign in to add a comment