New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640181 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

19.3%-338.5% regression in webrtc_perf_tests at 13757:13760

Project Member Reported by hlundin@chromium.org, Aug 23 2016

Issue description

Blame range: https://chromium.googlesource.com/external/webrtc/+log/f96c51ac057ec8e2cace58c5ecdfecce65a03a6d..4a1ec1e639b0e78ca1f189b19205782c4b9ab0af

4a1ec1e Added ProbeBitrate(bitrate_bps, num_probes) to BitrateProber. by philipel · 8 days ago
1aee0b5 Remove old methods in AudioTransport, make it pass a gn build by maxmorin · 8 days ago
c8c71f4 Revert of Move FilePlayer and FileRecorder to Voice Engine (patchset #6 id:100001 of https://codereview.webrtc.org/2240163002/ ) by kwiberg · 8 days ago
dc65ea2 Move FilePlayer and FileRecorder to Voice Engine by kwiberg · 8 days ago
 
Labels: -M-52 M-54
Owner: philipel@chromium.org
philipel: your CL looks like the most suspicious one.
Cc: peah@chromium.org

Comment 4 by philipel@google.com, Aug 23 2016

I haven't looked through all the graphs but I'm pretty certain most of the changes are due to my CL.

The reason for the change is that earlier we probed at x3 and x6 the initial start bitrate, but here we probe at 900 kbps and 1800 kbps regardless of the inital start bitrate.

This CL should undo the changes to these metrics:
https://codereview.webrtc.org/2269993002/

Comment 5 by peah@chromium.org, Oct 21 2016

Any updates on this? Can this be closed?
Status: Fixed (was: Assigned)
This has been fixed, closing.

Sign in to add a comment