Issue metadata
Sign in to add a comment
|
6.4%-14.2% regression in webrtc_perf_tests at 13728:13729 |
||||||||||||||||||||
Issue descriptionBlame range: f10976e Roll chromium_revision db8d32de07..941118827f (410624:411223) by kjellander · 12 days ago 3b74768 Remove pbos@webrtc.org from WATCHLISTS. by Peter Boström · 12 days ago The culprit must be the chromium roll.
,
Aug 23 2016
kjellander: please take a look, and close if the change seems reasonable with your roll of Chromium into WebRTC.
,
Aug 23 2016
,
Aug 23 2016
Yeah, since it's including a libvpx roll I would assume smaller variations like this are to be expected. marpan: can you confirm and close if it seems reasonable? It's a bit weird it's only hitting one device.
,
Aug 23 2016
What other devices are tested? We did remove some armv6 code, but added new optimizations a short time later: https://chromium.googlesource.com/chromium/src/+/3b352b0e6ff7180e8ce9f4bd79069a34220bd705 2016-08-12 linfengz NEON asm of vpx_lpf_{horizontal,vertical}_8_dual_neon() https://chromium.googlesource.com/chromium/src/+/db041e863ac318d054f13a16885a557c7cc93b5e 2016-08-03 linfengz NEON intrinsics for 4 loopfilter functions
,
Aug 23 2016
I didn't expect a regression this high, but I am working on replacing 3 other functions: https://bugs.chromium.org/p/webm/issues/detail?id=1273
,
Aug 24 2016
Jacky will take a look and try to reproduce with standalone libvpx.
,
Aug 24 2016
,
Aug 31 2016
Ran the same test on my nexus 5 using webrtc_perf test (conference_hd clip) and found that the removal of armv6 code (as mentioned in comment#5) in the Aug 11 roll causes ~8-10% regression in encode_time. The gain is mostly retrieved back with this CL https://chromium-review.googlesource.com/#/c/374664/ that was rolled into chromium yesterday (https://codereview.chromium.org/2295893002/) Will monitor the graphs in next few days to see if regression goes away.
,
Sep 7 2016
The regression is mostly recovered in the latest graphs, so I'll close (mark as fixed) the issue for now. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by hlundin@chromium.org
, Aug 23 2016