New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640162 link

Starred by 2 users
Status: Verified
Owner:
hungte@chromium.org
Closed: Jul 2017
Cc:
█ youcheng@chromium.org
█ phoenixshen@chromium.org
█ pihsun@chromium.org
█ littlecvr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 677904


Sign in to add a comment

Revise shopfloor proxy & factory server design

Project Member Reported by hungte@chromium.org, Aug 23 2016 
Currently the "shopfloor server" was a very confusing term in ChromiumOS factory flow, which sometimes refers to Google's server and sometimes partner's. With the change of moving to Umpire, we should revise the factory code and remove legacy support that:

 - Use "Google factory server" or "Umpire (particular for backend)" or "Dome (particular frontend)" or "Instalog" (particular log service)" to refer the server developed and deployed by Google.
 - Use "Partner shopfloor server" to refer the server in ODM or CM's factory.
 - "Shopfloor proxy" to indicate the services provided by Google Factory Server (usually via Umpire) that bridges calls into partner's shopfloor server.

In the code we want to make changes that
 - unify and define the location of shopfloor proxy handler in Umpire
 - define a new standard APIs that shopfloor proxy should provide
 - define a set of APIs that Google Factory Server (Umpire) should provide

... anything else?

Comment 1 by littlecvr@chromium.org, Dec 12 2016

Cc: phoenixshen@chromium.org youcheng@chromium.org pihsun@chromium.org

Comment 2 by hungte@chromium.org, Jan 25 2017

Blockedon: 677904
Owner: hungte@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/8e84b1dca7ee28b3ec4b72acc6707b6897b516cb

commit 8e84b1dca7ee28b3ec4b72acc6707b6897b516cb
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jan 26 10:22:52 2017

shopfloor: Deprecate unused API.

As the first step of cleaning shopfloor API, remove deprecated ones and
change the common implementation as default.

Removed:
 - GetVPD
 - GetHWID
 - GetRegistrationCodeMap
 - CheckSN
 - GetAuxData

Changed to common implementation:
 - UploadReport

BUG= chromium:640162 
TEST=make test

Change-Id: I7528b7d5d4609b0cbf08ca63be26dba405ebe9f2
Reviewed-on: https://chromium-review.googlesource.com/433482
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/8e84b1dca7ee28b3ec4b72acc6707b6897b516cb/py/shopfloor/__init__.py
[modify] https://crrev.com/8e84b1dca7ee28b3ec4b72acc6707b6897b516cb/py/shopfloor/template.py
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/8e84b1dca7ee28b3ec4b72acc6707b6897b516cb

commit 8e84b1dca7ee28b3ec4b72acc6707b6897b516cb
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jan 26 10:22:52 2017

shopfloor: Deprecate unused API.

As the first step of cleaning shopfloor API, remove deprecated ones and
change the common implementation as default.

Removed:
 - GetVPD
 - GetHWID
 - GetRegistrationCodeMap
 - CheckSN
 - GetAuxData

Changed to common implementation:
 - UploadReport

BUG= chromium:640162 
TEST=make test

Change-Id: I7528b7d5d4609b0cbf08ca63be26dba405ebe9f2
Reviewed-on: https://chromium-review.googlesource.com/433482
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/8e84b1dca7ee28b3ec4b72acc6707b6897b516cb/py/shopfloor/__init__.py
[modify] https://crrev.com/8e84b1dca7ee28b3ec4b72acc6707b6897b516cb/py/shopfloor/template.py
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/3262703907cda5799616d9a6b26114bdfcad317c

commit 3262703907cda5799616d9a6b26114bdfcad317c
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Mar 28 05:41:03 2017
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/341bbb66f21913ce36794fdb1af8ab427727fc04

commit 341bbb66f21913ce36794fdb1af8ab427727fc04
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Mar 29 18:42:17 2017
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/087cb351782b1ba1e036ba7d868d4772ed267789

commit 087cb351782b1ba1e036ba7d868d4772ed267789
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Mar 31 12:31:46 2017
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/2662285480fc9767f85eb2aa7ad6ab8004be2940

commit 2662285480fc9767f85eb2aa7ad6ab8004be2940
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Mar 31 12:31:46 2017
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/a3f4e77cf5231b50369a24c8960b1805856f4fc6

commit a3f4e77cf5231b50369a24c8960b1805856f4fc6
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Apr 06 02:14:19 2017
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/a3f4e77cf5231b50369a24c8960b1805856f4fc6

commit a3f4e77cf5231b50369a24c8960b1805856f4fc6
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Apr 06 02:14:19 2017
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/a13ded7b1922649fa2b98adef3838332637ee484

commit a13ded7b1922649fa2b98adef3838332637ee484
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Apr 06 03:30:47 2017
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 14 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/5daf91132fae1acd02adc43361402feee995ffbd

commit 5daf91132fae1acd02adc43361402feee995ffbd
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Jun 14 19:23:06 2017
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/81969990687765e3b1323a7ada7e85cc52353383

commit 81969990687765e3b1323a7ada7e85cc52353383
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jun 15 14:07:39 2017

test: Change device data path in run_if expression.

The reference to device data has been changed to 'device.' in run_if
expressions.

BUG= chromium:640162 
TEST=make test

Change-Id: I43236f3092560681327642d278b00a88e9bcdb33
Reviewed-on: https://chromium-review.googlesource.com/536537
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/81969990687765e3b1323a7ada7e85cc52353383/py/test/test_lists/generic_run_in.py
[modify] https://crrev.com/81969990687765e3b1323a7ada7e85cc52353383/py/test/test_lists/generic_smt.py
[modify] https://crrev.com/81969990687765e3b1323a7ada7e85cc52353383/py/test/pytests/rf_radiated/rf_radiated.py
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/61389d7f3f93c4f7d8e7f8439fefd04f7057e19d

commit 61389d7f3f93c4f7d8e7f8439fefd04f7057e19d
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jun 16 13:52:37 2017

shopfloor: Migrate old shopfloor to use new shopfloor service API.

The new "shopfloor service API" has defined how the shopfloor backend
should be implemented, and also deprecated the design of "shopfloor
module", which makes it easier to run same flow (with same test list)
across different ODMs.

As the first step, change the shopfloor_server implementation to stop
loading modules, and only accepting shopfloor service URL.

Since no more modules should be inheriting ShopFloorBase in future,
shopfloor/__init__.py is now back to empty file, and the non-shopfloor
part (those only made for ChromeOS factory flow) are moved to a
"factory_server.FactoryServer", with shopfloor service APIs included.

simple_rma_shopfloor and simple_shopfloor are no longer needed.

BUG= chromium:640162 
TEST=make test

Change-Id: I2e27de35596740aaa00354e6791d639e7e4d2183
Reviewed-on: https://chromium-review.googlesource.com/536538
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@chromium.org>

[delete] https://crrev.com/aacbc2f20aeab039cfe8935abd88db0b0f37292d/py/shopfloor/shopfloor_server.py
[add] https://crrev.com/61389d7f3f93c4f7d8e7f8439fefd04f7057e19d/py/shopfloor/factory_server.py
[rename] https://crrev.com/61389d7f3f93c4f7d8e7f8439fefd04f7057e19d/py/shopfloor/factory_server_par_unittest.py
[delete] https://crrev.com/aacbc2f20aeab039cfe8935abd88db0b0f37292d/py/shopfloor/simple_shopfloor.py
[delete] https://crrev.com/aacbc2f20aeab039cfe8935abd88db0b0f37292d/py/shopfloor/simple_rma_shopfloor.py
[modify] https://crrev.com/61389d7f3f93c4f7d8e7f8439fefd04f7057e19d/py/shopfloor/__init__.py
[delete] https://crrev.com/aacbc2f20aeab039cfe8935abd88db0b0f37292d/py/shopfloor/template.py
[delete] https://crrev.com/aacbc2f20aeab039cfe8935abd88db0b0f37292d/py/shopfloor/simple_shopfloor_unittest.py
[modify] https://crrev.com/61389d7f3f93c4f7d8e7f8439fefd04f7057e19d/py/test/shopfloor.py
[delete] https://crrev.com/aacbc2f20aeab039cfe8935abd88db0b0f37292d/py/shopfloor/simple_rma_shopfloor_unittest.py
[modify] https://crrev.com/61389d7f3f93c4f7d8e7f8439fefd04f7057e19d/py/shopfloor/dummy_updater.py
[delete] https://crrev.com/aacbc2f20aeab039cfe8935abd88db0b0f37292d/py/shopfloor/shopfloor_unittest.py
[modify] https://crrev.com/61389d7f3f93c4f7d8e7f8439fefd04f7057e19d/bin/shopfloor_server
[modify] https://crrev.com/61389d7f3f93c4f7d8e7f8439fefd04f7057e19d/doc/shopfloor_api.rst
[add] https://crrev.com/61389d7f3f93c4f7d8e7f8439fefd04f7057e19d/py/shopfloor/factory_server_unittest.py
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 21 2017

Labels: merge-merged-factory-eve-9667.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/609c425893ec2a19af15fda10a9e30c399bb8233

commit 609c425893ec2a19af15fda10a9e30c399bb8233
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Jun 21 01:02:01 2017

CHERRY-PICK: umpire: Change dynamic shopfloor handler to static Shopfloor Service API.

Umpire designed supporting shopfloor handlers in a very dynamic way, to
help different clients being able to connect to the associated handlers.

However, we find that introducing more troubles because:
 - It becomes impossible to "lock" shopfloor code when we need to deal
   with lots of local changes in toolkit across many developers.
 - Umpire now runs inside Docker and the dependency of board handlers
   may break easily, from Python package to port & directory binding.
 - The shopfloor handlers don't work pretty well when we update package
   in place.
 - Running multiple handlers under FastCGI also made syncing more
   difficult.

Comparing with what's needed in practice, it is believed that calls to
shopfloor backends should be isolated, defined with clear interface,
and no difference for devices in same build. If there will be any
special rule, it should be implemented directly on server side, not the
handler proxy.

BUG= chromium:640162 
TEST=make test; ./setup/cros_docker.sh build; cros_docker.sh umpire test
     installed cros_docker, start Dome, created an Umpire session.

Change-Id: Ib2f8e4876bbd7375a1f19db91f1006703050fa4b
Original-Change-Id: If485a19e46bae3dfd24cb57eb87302bded4b2fa4
Reviewed-on: https://chromium-review.googlesource.com/537273
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/542158
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>
Commit-Queue: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/test/shopfloor.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/config/umpire_default.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/umpired.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/umpire_env.py
[delete] https://crrev.com/d8d35319ecc8e9ba8261268e0590c333dc053b32/py/umpire/shop_floor_launcher.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/docker/default_umpire.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/README.md
[delete] https://crrev.com/d8d35319ecc8e9ba8261268e0590c333dc053b32/py/umpire/service/archiver_unittest.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/commands/deploy.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/testdata/minimal_umpire.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/commands/import_bundle.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/client/umpire_server_proxy_unittest.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/e2e_test.py
[delete] https://crrev.com/d8d35319ecc8e9ba8261268e0590c333dc053b32/py/umpire/e2e_test/testdata/umpire/toolkits/device/067f0398c038261d7f4ab9706850c280/usr/local/factory/py/umpire/test_shop_floor_handler.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/service/http.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/config/umpire_deploy.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/client/testdata/resourcemap1
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/client/testdata/resourcemap2
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/rpc_dut.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/common.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/testdata/minimal_empty_services_umpire.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/service/instalog.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/testdata/default_umpire.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/testdata/umpired_test.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/umpire/active_umpire.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/config/umpire_deploy_fail.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/config/umpire_deploy_service_config_changed.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/testdata/minimal_empty_services_with_enable_update_umpire.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/client/umpire_server_proxy.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/testdata/enable_update.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/test/pytests/finalize/finalize.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/commands/status_reporter.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/testdata/umpire_resource_check.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/umpire_env_unittest.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/service/shop_floor.py
[delete] https://crrev.com/d8d35319ecc8e9ba8261268e0590c333dc053b32/py/umpire/service/archiver.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/bundle_selector.py
[delete] https://crrev.com/d8d35319ecc8e9ba8261268e0590c333dc053b32/py/umpire/shop_floor_manager_unittest.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/config/umpire_wrong_schema.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/umpired_unittest.py
[delete] https://crrev.com/d8d35319ecc8e9ba8261268e0590c333dc053b32/py/umpire/shop_floor_manager.py
[rename] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/umpire/resources/umpire.1d346c8cabfb9148ce3c2be66ec3f1fa.yaml
[delete] https://crrev.com/d8d35319ecc8e9ba8261268e0590c333dc053b32/py/umpire/service/shop_floor_unittest.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/config/umpire_deploy_proxy.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/commands/testdata/minimal_empty_services_umpire.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/config.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/config/umpire_with_resource.yaml
[delete] https://crrev.com/d8d35319ecc8e9ba8261268e0590c333dc053b32/py/umpire/shop_floor_handler.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/umpire.py
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/config/umpire_missing_resource.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/testdata/rulesets_umpire.yaml
[modify] https://crrev.com/609c425893ec2a19af15fda10a9e30c399bb8233/py/umpire/e2e_test/testdata/config/umpire_no_service.yaml
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/4c5f54a19d24d98e54fc837b9277bff054f06ee7

commit 4c5f54a19d24d98e54fc837b9277bff054f06ee7
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Jun 21 01:02:04 2017

CHERRY-PICK: cutoff: Change Finalize and FinalizeFQC to Shopfloor Service API NotifyEvent.

The Finalize and FinalizeFQC functions should be replaced by new
NotifyEvent, with event code as Finalize and Refinalize.

In Shopfloor Service API, the first parameter can be a
FactoryDeviceData; and in first implementation we only include serial
number.

Also revised cutoff and inform scripts to use curl and display TTY in
a way easier to debug.

BUG= chromium:640162 
TEST=SERIAL_NUMBER=12345 ./generate_finalize_request factory_reset > x

Change-Id: Ide08eaf2a87a83a57a6f2281523c74a63795dc60
Original-Change-Id: Iea2a01b611a30a6d9f032cd8fa26d1efd0d63306
Reviewed-on: https://chromium-review.googlesource.com/538734
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/542159
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>
Commit-Queue: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/4c5f54a19d24d98e54fc837b9277bff054f06ee7/sh/cutoff/inform_shopfloor.sh
[modify] https://crrev.com/4c5f54a19d24d98e54fc837b9277bff054f06ee7/sh/cutoff/options.sh
[modify] https://crrev.com/4c5f54a19d24d98e54fc837b9277bff054f06ee7/sh/cutoff/cutoff.sh
[modify] https://crrev.com/4c5f54a19d24d98e54fc837b9277bff054f06ee7/sh/cutoff/generate_finalize_request.sh
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/b119e41c526e6309ed5d9435c4071441bb00c1b4

commit b119e41c526e6309ed5d9435c4071441bb00c1b4
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Jun 21 11:19:06 2017

shopfloor: Add document for Shopfloor Service API specification.

The migrating to Shopfloor Service is ready for both legacy factory
server and Umpire, so we should publish the documents.

BUG= chromium:640162 
TEST=None

Change-Id: Iab4a3a388e23406918a6bfe375403cfa50a8e079
Reviewed-on: https://chromium-review.googlesource.com/539439
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[add] https://crrev.com/b119e41c526e6309ed5d9435c4071441bb00c1b4/py/shopfloor/shopfloor_service.py
[add] https://crrev.com/b119e41c526e6309ed5d9435c4071441bb00c1b4/py/shopfloor/README.md
[add] https://crrev.com/b119e41c526e6309ed5d9435c4071441bb00c1b4/doc/images/shopfloor_service_topology.png
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/18cf83c7844974f8ba2fedc0c37cae32f8cdb90e

commit 18cf83c7844974f8ba2fedc0c37cae32f8cdb90e
Author: Hung-Te Lin <hungte@chromium.org>
Date: Sat Jun 24 21:59:51 2017

shopfloor: Clean up legacy shopfloor server invocation.

For migration to new shopfloor service, we have few changes needed:

1. Remove region database. factory_server itself does not need region,
   and shopfloor service may include that by itself if needed.
2. 'factory_toolkit' is officially replaced by 'toolkit' in build script.
3. Symlink 'factory_server' should be added into bundle shopfloor/ folder.
4. Updated shopfloor/README.md to explain how to setup shopfloor server URL.
5. Added a factory_server.json for projects to configure that
   permanently for factory_server.

BUG= chromium:640162 
TEST=make test

Change-Id: I1779a54c23a9858d7cba15ce3dbe714bc0575cba
Reviewed-on: https://chromium-review.googlesource.com/544369
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/18cf83c7844974f8ba2fedc0c37cae32f8cdb90e/py/shopfloor/factory_server.py
[add] https://crrev.com/18cf83c7844974f8ba2fedc0c37cae32f8cdb90e/py/shopfloor/factory_server.schema.json
[modify] https://crrev.com/18cf83c7844974f8ba2fedc0c37cae32f8cdb90e/Makefile
[modify] https://crrev.com/18cf83c7844974f8ba2fedc0c37cae32f8cdb90e/devtools/mk/bundle.sh
[add] https://crrev.com/18cf83c7844974f8ba2fedc0c37cae32f8cdb90e/py/shopfloor/factory_server.json
[modify] https://crrev.com/18cf83c7844974f8ba2fedc0c37cae32f8cdb90e/py/shopfloor/README.md
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/1fabeeeee6708ad2d6eb88eaffa6dbdc1f789f2e

commit 1fabeeeee6708ad2d6eb88eaffa6dbdc1f789f2e
Author: Hung-Te Lin <hungte@chromium.org>
Date: Sat Jun 24 21:59:51 2017

state: Rename ALL_SERIAL_NUMBERS to SERIALS.

To make it easier for both server and clients to set and access serial
numbers, rename the 'all_serial_numbers' name space into 'serials'.

Also updated related documents and provided better information in state
help string.

BUG= chromium:640162 
TEST=make test

Change-Id: I50ec2e2dea12f9cd388d1d70234b3f6377881908
Reviewed-on: https://chromium-review.googlesource.com/544591
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/1fabeeeee6708ad2d6eb88eaffa6dbdc1f789f2e/py/test/test_lists/generic_smt.py
[modify] https://crrev.com/1fabeeeee6708ad2d6eb88eaffa6dbdc1f789f2e/py/goofy/invocation.py
[modify] https://crrev.com/1fabeeeee6708ad2d6eb88eaffa6dbdc1f789f2e/py/test/state.py
[modify] https://crrev.com/1fabeeeee6708ad2d6eb88eaffa6dbdc1f789f2e/doc/regions.rst
[modify] https://crrev.com/1fabeeeee6708ad2d6eb88eaffa6dbdc1f789f2e/py/test/pytests/vpd.py
[modify] https://crrev.com/1fabeeeee6708ad2d6eb88eaffa6dbdc1f789f2e/py/test/test_lists/generic_run_in.py
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/8736ba6107e298ee9aa0ed036657ce2e5d242a28

commit 8736ba6107e298ee9aa0ed036657ce2e5d242a28
Author: Hung-Te Lin <hungte@chromium.org>
Date: Sat Jun 24 21:59:52 2017

pytests: Add shopfloor_service test.

The new Shopfloor Service has defined more clearly on how shopfloor
should be invoked, so we can have a better client that knows better for
how to invoke Shopfloor commands.

The new shopfloor_service pytest is a client based on Shopfloor Service API.
The factory flow may call with with minimized arguments, for example:

  FactoryTest(pytest_name='shopfloor_service',
              dargs={
                method='NotifyStart',
                args: ['SMT']})

No more lambda functions nor implicit evaluation.

BUG= chromium:640162 
TEST=make test

Change-Id: I835bd6a6ada0b3f03a0a3088c3f9c3bf34dbec92
Reviewed-on: https://chromium-review.googlesource.com/545377
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[add] https://crrev.com/8736ba6107e298ee9aa0ed036657ce2e5d242a28/py/test/pytests/shopfloor_service.py
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/0a612ea8e6bfb96f1bd3fed0f3cc0af0a06e9962

commit 0a612ea8e6bfb96f1bd3fed0f3cc0af0a06e9962
Author: Hung-Te Lin <hungte@chromium.org>
Date: Sat Jun 24 21:59:52 2017

pytests: Improve write_device_data to support writing all VPD sections.

With the help of new device data definition, it's very clear for how and
where to get VPD values to set. As a result, write_device_data_to_vpd
should be able write all (RO+RW) VPD entries by default.

BUG= chromium:640162 
TEST=manually tested.

Change-Id: Id02e9e3b3f57e18d35c017717465a4649bed00f0
Reviewed-on: https://chromium-review.googlesource.com/547217
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/0a612ea8e6bfb96f1bd3fed0f3cc0af0a06e9962/py/test/pytests/write_device_data_to_vpd.py
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/6dd8cfbe440d0bb5268e532389b24816aa1332ec

commit 6dd8cfbe440d0bb5268e532389b24816aa1332ec
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jun 30 11:53:40 2017

pytests: Merge vpd into update_device_data test.

The 'vpd' test has few functions.

 - Reading value from shopfloor is replaced by GetDeviceInfo and
   write_device_data_to_vpd.
 - From device_data is done by write_device_data_to_vpd.

The left one, "set manually" can be extended to allow modifying any
device data so we should merge it with update_device_data.

The new update_device_data now accepts two arguments:
 - manual_input: True to allow OP entering data manually (usually for
   RMA).
 - fields: A list of fields to update, as tuple (key, value, label,
   check_value) - same format from legacy vpd test.

BUG= chromium:736356 , chromium:640162 
TEST=manually executed update_device_data.

Change-Id: I4c41323cfa6bfa3dde983a0eb316120a0d94c842
Reviewed-on: https://chromium-review.googlesource.com/547220
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/6dd8cfbe440d0bb5268e532389b24816aa1332ec/py/test/shopfloor.py
[modify] https://crrev.com/6dd8cfbe440d0bb5268e532389b24816aa1332ec/py/test/pytests/update_device_data.py
[modify] https://crrev.com/6dd8cfbe440d0bb5268e532389b24816aa1332ec/po/zh-CN.po
[delete] https://crrev.com/7e5e2b7f6d6d43c868f4f7b8d0feb853ad3712aa/py/test/pytests/vpd.py
[delete] https://crrev.com/7e5e2b7f6d6d43c868f4f7b8d0feb853ad3712aa/py/test/pytests/vpd_unittest.py
[modify] https://crrev.com/6dd8cfbe440d0bb5268e532389b24816aa1332ec/py/test/test_lists/generic_run_in.py
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/6dd8cfbe440d0bb5268e532389b24816aa1332ec

commit 6dd8cfbe440d0bb5268e532389b24816aa1332ec
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jun 30 11:53:40 2017

pytests: Merge vpd into update_device_data test.

The 'vpd' test has few functions.

 - Reading value from shopfloor is replaced by GetDeviceInfo and
   write_device_data_to_vpd.
 - From device_data is done by write_device_data_to_vpd.

The left one, "set manually" can be extended to allow modifying any
device data so we should merge it with update_device_data.

The new update_device_data now accepts two arguments:
 - manual_input: True to allow OP entering data manually (usually for
   RMA).
 - fields: A list of fields to update, as tuple (key, value, label,
   check_value) - same format from legacy vpd test.

BUG= chromium:736356 , chromium:640162 
TEST=manually executed update_device_data.

Change-Id: I4c41323cfa6bfa3dde983a0eb316120a0d94c842
Reviewed-on: https://chromium-review.googlesource.com/547220
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/6dd8cfbe440d0bb5268e532389b24816aa1332ec/py/test/shopfloor.py
[modify] https://crrev.com/6dd8cfbe440d0bb5268e532389b24816aa1332ec/py/test/pytests/update_device_data.py
[modify] https://crrev.com/6dd8cfbe440d0bb5268e532389b24816aa1332ec/po/zh-CN.po
[delete] https://crrev.com/7e5e2b7f6d6d43c868f4f7b8d0feb853ad3712aa/py/test/pytests/vpd.py
[delete] https://crrev.com/7e5e2b7f6d6d43c868f4f7b8d0feb853ad3712aa/py/test/pytests/vpd_unittest.py
[modify] https://crrev.com/6dd8cfbe440d0bb5268e532389b24816aa1332ec/py/test/test_lists/generic_run_in.py
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/dcc76512ff2329a4f5b646e5c2b3a79afab8d357

commit dcc76512ff2329a4f5b646e5c2b3a79afab8d357
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Jul 03 09:39:31 2017

pytests: shopfloor_service: Support ActivateRegCode API.

The ActivateRegCode API takes 3 privacy arguments: ubind, gbind, hwid
(hwid has no privacy concern). To prevent run-time evaluation in test
list, the preparation of args should be done in shopfloor_service
pytest.

This change adds extra spec to invoke ActivateRegCode properly, with
arguments filtered so it won't be logged accidentally.

BUG= chromium:640162 
TEST=manually tested.

Change-Id: I43c1ec9d2d56d348f024b7086c8119a8ab856271
Reviewed-on: https://chromium-review.googlesource.com/548515
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/dcc76512ff2329a4f5b646e5c2b3a79afab8d357/py/test/pytests/shopfloor_service.py
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/38dedf280a4787a330b58e93cc246de53c12d7ed

commit 38dedf280a4787a330b58e93cc246de53c12d7ed
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Jul 04 13:51:00 2017

pytests: Change sync_shopfloor to improved sync_factory_server.

With the new Shopfloor Service API, we should eliminate the need of
arbitrary call_shopfloor test. The first step is to make sure all
"standard" functions provided by factory server can be done by simple
switches, in sync_factory_server test (previously sync_shopfloor.py).

This change adds better docs, and changes all its sub-functions (sync
time, sync event_log, update_toolkit) to be selective by arguments.

BUG= chromium:640162 
TEST=make test

Change-Id: I3dd86f4b3a2107f72df4e89aac29cd47c9d63d7f
Reviewed-on: https://chromium-review.googlesource.com/558592
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Youcheng Syu <youcheng@chromium.org>

[modify] https://crrev.com/38dedf280a4787a330b58e93cc246de53c12d7ed/py/test/test_lists/generic_tsab.py
[delete] https://crrev.com/727fda622a9ff356960b79e95dfd03a97b5d0a82/py/test/pytests/sync_shopfloor.py
[modify] https://crrev.com/38dedf280a4787a330b58e93cc246de53c12d7ed/py/test/test_lists/firmware_stress.py
[modify] https://crrev.com/38dedf280a4787a330b58e93cc246de53c12d7ed/po/zh-CN.po
[delete] https://crrev.com/727fda622a9ff356960b79e95dfd03a97b5d0a82/py/test/pytests/flush_event_logs.py
[modify] https://crrev.com/38dedf280a4787a330b58e93cc246de53c12d7ed/py/test/test_lists/generic.py
[modify] https://crrev.com/38dedf280a4787a330b58e93cc246de53c12d7ed/py/test/test_lists/generic_vswr.py
[modify] https://crrev.com/38dedf280a4787a330b58e93cc246de53c12d7ed/py/test/test_lists/generic_run_in.py
[add] https://crrev.com/38dedf280a4787a330b58e93cc246de53c12d7ed/py/test/pytests/sync_factory_server.py
[modify] https://crrev.com/38dedf280a4787a330b58e93cc246de53c12d7ed/py/test/test_lists/generic_smt.py
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/24dd727038a3807544ffa26b75e98c12374648a5

commit 24dd727038a3807544ffa26b75e98c12374648a5
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Jul 04 13:51:00 2017

pytests: Add 'upload_report' to sync_factory_server.

The call_shopfloor#UploadReport is now officially supported by
sync_factory_server[upload_report=True].

BUG= chromium:640162 
TEST=make test; manually tested.

Change-Id: I71f2cb3d566eaaa11f62fb5647f0eb069f9a7ea9
Reviewed-on: https://chromium-review.googlesource.com/558593
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[modify] https://crrev.com/24dd727038a3807544ffa26b75e98c12374648a5/po/zh-CN.po
[modify] https://crrev.com/24dd727038a3807544ffa26b75e98c12374648a5/py/test/pytests/sync_factory_server.py
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/ae5665ba70b2e2ea442556be7dd03149fab10bf5

commit ae5665ba70b2e2ea442556be7dd03149fab10bf5
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Jul 05 21:24:43 2017

pytests: Change write_device_data_to_vpd to take ro_key_map and rw_key_map.

Change the key_map and vpd_section into ro_key_map and rw_key_map so it
is easier to write both RO and RW data in a single invocation.

BUG= chromium:640162 
TEST=make test; manually executed write_device_data_to_vpd test.

Change-Id: I4af0ab25d5c7b37f02f6a003d9539360e6bd12dd
Reviewed-on: https://chromium-review.googlesource.com/558860
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/ae5665ba70b2e2ea442556be7dd03149fab10bf5/py/test/pytests/write_device_data_to_vpd.py
Project Member

Comment 28 by bugdroid1@chromium.org, Jul 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/a36c03a37d5ab46f3520237ce192d9c15f294e07

commit a36c03a37d5ab46f3520237ce192d9c15f294e07
Author: Hung-Te Lin <hungte@chromium.org>
Date: Wed Jul 05 21:24:43 2017

pytests: Change read_device_data_from_vpd to take ro_key_map and rw_key_map.

Change the key_map and vpd_section into ro_key_map and rw_key_map so it
is easier to read both RO and RW data in a single invocation.

BUG= chromium:640162 
TEST=make test; manually executed read_device_data_from_vpd test.

Change-Id: I95f8ff0272d19bb2cbcd7011195c3cfa0e08dd52
Reviewed-on: https://chromium-review.googlesource.com/559248
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/a36c03a37d5ab46f3520237ce192d9c15f294e07/py/test/pytests/read_device_data_from_vpd.py
Project Member

Comment 29 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-soraka-private/+/25fccdc2ecfedef2b9e08bf93faafbac6969a5d7

commit 25fccdc2ecfedef2b9e08bf93faafbac6969a5d7
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jul 06 12:00:30 2017
Project Member

Comment 30 by bugdroid1@chromium.org, Jul 6 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-poppy-private/+/f892fa38a7a486ee8e2e0a24d7c251e136a54cc5

commit f892fa38a7a486ee8e2e0a24d7c251e136a54cc5
Author: Hung-Te Lin <hungte@chromium.org>
Date: Thu Jul 06 12:00:30 2017
Project Member

Comment 31 by bugdroid1@chromium.org, Jul 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/5a0958972bf64cf1dc6cfd9e5116776dc46946ef

commit 5a0958972bf64cf1dc6cfd9e5116776dc46946ef
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jul 07 12:58:33 2017

test: Fix KeyError when calling device_data.CheckValidDeviceDataKey.

The check of top level key prefix was incorrectly using whole key so
updating device data with full key path would raise KeyError.

BUG= chromium:640162 ,b:38154177
TEST=make test

Change-Id: I5f5511219fc56c195576cf3cfb51c08fbd7c5ec7
Reviewed-on: https://chromium-review.googlesource.com/562850
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/5a0958972bf64cf1dc6cfd9e5116776dc46946ef/py/test/device_data.py
Project Member

Comment 32 by bugdroid1@chromium.org, Jul 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/6e743876ff28d61bcf2da489f8e702369845f8bc

commit 6e743876ff28d61bcf2da489f8e702369845f8bc
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Jul 10 22:27:25 2017

write_device_data_to_vpd: Match read_device_data_from_vpd

Change pytest write_device_data_to_vpd so it writes the same key set as
what read_device_data_from_vpd reads from vpd.

BUG= chromium:640162 
TEST=make test
TEST=manually on DUT

Change-Id: Ic8c01248d83d458e67fb7646beacd7909c05e46b
Reviewed-on: https://chromium-review.googlesource.com/564101
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/6e743876ff28d61bcf2da489f8e702369845f8bc/py/test/pytests/write_device_data_to_vpd.py
Project Member

Comment 33 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/42b61ae3c244ec0069f487aba39266bd577c1ca5

commit 42b61ae3c244ec0069f487aba39266bd577c1ca5
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Jul 11 05:35:09 2017

pytests: Deprecate call_shopfloor by shopfloor_service.

The `call_shopfloor` should be deprecated since Factory Server related
calls are now managed by sync_factory_server (and Instalog) and
shopfloor backend calls should be handled by shopfloor_service.

This change revised documentation of shopfloor_service and adds an extra
``raw_invocation`` mode for simple XMLRPC calls like interaction to
fixtures.

Complicated calls should be discussed and implemented by either
extending Shopfloor Service Specification or add a dedicated new test.

BUG= chromium:640162 
TEST=manually tested.

Change-Id: Ib3c0bc58a31c65c1e124ca4e8c898a462f582098
Reviewed-on: https://chromium-review.googlesource.com/565079
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/42b61ae3c244ec0069f487aba39266bd577c1ca5/po/zh-CN.po
[delete] https://crrev.com/1832300af808f575778d05b026ac56b72b906c57/py/test/pytests/call_shopfloor.py
[modify] https://crrev.com/42b61ae3c244ec0069f487aba39266bd577c1ca5/py/test/pytests/shopfloor_service.py
Project Member

Comment 34 by bugdroid1@chromium.org, Jul 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/1832300af808f575778d05b026ac56b72b906c57

commit 1832300af808f575778d05b026ac56b72b906c57
Author: Hung-Te Lin <hungte@chromium.org>
Date: Tue Jul 11 05:35:09 2017

pytests: Remove shopfloor invocation from memory_size.

With the standardization of shopfloor API, we should not let individual
test items invoke arbitrary shopfloor calls. Instead, it's all now done
inside Device Data.

Test `memory_size` is now reading from device data instead of calling
GetMemorySize from shopfloor.

BUG= chromium:640162 
TEST=make test; run manually.

Change-Id: I07e8e32f1ef8b39fabc489e6d416c66277080119
Reviewed-on: https://chromium-review.googlesource.com/565218
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/1832300af808f575778d05b026ac56b72b906c57/po/zh-CN.po
[modify] https://crrev.com/1832300af808f575778d05b026ac56b72b906c57/py/test/pytests/memory_size.py

Comment 35 by hungte@chromium.org, Jul 12 2017

Status: Started (was: Assigned)
Project Member

Comment 36 by bugdroid1@chromium.org, Jul 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/7ba0cc03d2cc73cba52a4905f95964db2e3aaa16

commit 7ba0cc03d2cc73cba52a4905f95964db2e3aaa16
Author: Hung-Te Lin <hungte@chromium.org>
Date: Sat Jul 15 10:01:20 2017

pytests: Deprecate select_components by update_device_data.

The select_components was designed for RMA by selecting device data from
HWID config file, but it's usually used to select availability of
peripherals for example "component.has_touchscreen" today, also keyboard
layout (VPD region today).

As a result, it should be replaced by update_device_data.

update_device_data used to only support string type values in
interactive mode, but selection of components.* needs to write boolean
values so we have to support that by allowing True/False in 'value'
field, also [True, False] in value_check field.

BUG= chromium:640162 
TEST=make test; also manually executed update_device_data.py.

Change-Id: Iaeb42f8f4c2e10a20adfd1a363cf453e49feca0c
Reviewed-on: https://chromium-review.googlesource.com/571565
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/7ba0cc03d2cc73cba52a4905f95964db2e3aaa16/po/zh-CN.po
[delete] https://crrev.com/df733bcaa3161b3aeebd315ca1cea358f96522b8/py/test/pytests/select_components_static/select_components.js
[delete] https://crrev.com/df733bcaa3161b3aeebd315ca1cea358f96522b8/py/test/pytests/select_components.py
[modify] https://crrev.com/7ba0cc03d2cc73cba52a4905f95964db2e3aaa16/py/test/pytests/update_device_data.py

Comment 37 by hungte@chromium.org, Jul 26 2017

Status: Verified (was: Started)
Project Member

Comment 38 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/63e587f9aced4c4209be17ea99f48505e8493dec

commit 63e587f9aced4c4209be17ea99f48505e8493dec
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Fri Aug 25 10:24:43 2017

goofy: Remove argument dummy_shopfloor.

After CL:536538, factory_server (former shopfloor_server) doesn't
support argument '--dummy' anymore. We can remove the corresponding
argument argument '--dummy_shopfloor' from goofy.

BUG= chromium:640162 
TEST=make test

Change-Id: I355aef912deb9a34bfd30b0947c2e72f5c816e90
Reviewed-on: https://chromium-review.googlesource.com/634845
Commit-Ready: Youcheng Syu <youcheng@chromium.org>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/63e587f9aced4c4209be17ea99f48505e8493dec/py/goofy/goofy.py
Project Member

Comment 39 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/450fcdb88438d57878cdbca22c0dc21b65622eb0

commit 450fcdb88438d57878cdbca22c0dc21b65622eb0
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Tue Aug 29 01:21:32 2017

bin: Rename shopfloor_server to factory_server.

shopfloor_server has been renamed to factory_server in CL:536538. Also
rename the symlink for consistent.

BUG= chromium:640162 
TEST=make test

Change-Id: Ib2882e09e14b3c8190c98234f9c810405b5c95f5
Reviewed-on: https://chromium-review.googlesource.com/634846
Commit-Ready: Youcheng Syu <youcheng@chromium.org>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[rename] https://crrev.com/450fcdb88438d57878cdbca22c0dc21b65622eb0/bin/factory_server
[modify] https://crrev.com/450fcdb88438d57878cdbca22c0dc21b65622eb0/py/shopfloor/factory_server_par_unittest.py
►

Sign in to add a comment