After clicking on a bookmark in a folder of the BMB, there appears a multiple pressed state animation |
||||||||||||
Issue descriptionVersion: Chrome 54.0.2837.0 canary (64-bit) OS: Mac OS 10.11.6 What steps will reproduce the problem? (1) Click on a bookmark in a folder of the Bookmarks Bar What is the expected output? Just one pressed state animation What do you see instead? There appears a multiple pressed state animation. May be we can change this to a single pressed state animation. Please use labels and text to provide additional information. This is not a regression. Not sure, why we do this but this looks like a bug to me. Thanks. Mehmet
,
Aug 23 2016
Of course, please find the screencast attached. When I click on the Google Bookmark in the folder, you'll notice the multiple pressed state (blinking) animation. Please let me know, if you need more information. Thanks.
,
Aug 23 2016
,
Aug 23 2016
Oh, got it. Thank you. This is expected behavior, I assume to mimic native Mac menus. I notice, though, that Mac menu items only flash once, so maybe we should do that too instead of flash multiple times. bettes@ - I don't know if you're a good person to ask about this?
,
Sep 19 2016
I think flashing once is preferred over what we do today. Thanks!
,
Sep 19 2016
Thank you bettes@. spqchan@ - I'm assigning this one to you but there's no rush.
,
Aug 18 2017
Issue 756272 has been merged into this issue.
,
Nov 9 2017
,
Nov 10 2017
It looks like the flashing might be caused by AppKit. I'll play around to see what I can do about this
,
Nov 10 2017
Never mind, I figured it out
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5e61168e5aa92de8274a0c7167f794317cc59b9 commit b5e61168e5aa92de8274a0c7167f794317cc59b9 Author: spqchan <spqchan@chromium.org> Date: Mon Nov 13 22:13:52 2017 [Mac] Reduce flashes in bookmark menu item Currently when you click on an item in a folder on the bookmarks bar, the item will flash several times to provide feedback to the user. This CL reduces the flashing so that it will only flash once before closing the menu. Bug: 640138 Change-Id: I7bbc51ae0f4c4a1aac1d908b41984efb310f3854 Reviewed-on: https://chromium-review.googlesource.com/765094 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#516076} [modify] https://crrev.com/b5e61168e5aa92de8274a0c7167f794317cc59b9/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
Nov 13 2017
,
Nov 15 2017
Thanks, spqchan@. LGTM in Chrome Canary Version 64.0.3269.0 on macOS 10.12.6. Changing the Milestone to M64. Please feel free to change to M63, if desired. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by shrike@chromium.org
, Aug 23 2016