Quick View: Time metadata is wrapped In a strange position. |
||||||||||||
Issue descriptionPM or AM can be positioned in a new line. Maybe we could tweak the margin size for it to fix into one line. Example: May 24, 2016, 8:09 PM
,
Nov 15 2016
,
Sep 5 2017
I noticed this too. Agree we should have it fit into one line. We should test with the longest possible date string to make sure it works for all cases. sgabriel@ do you have guidance on how to solve this? Should we move the margin or make the panel bigger?
,
Sep 5 2017
,
Sep 8 2017
We can probably start by reducing the left padding by half (I assume that would be 16). Would it work for that? Do we know which language gives the longer string and if it would work in that case?
,
Sep 8 2017
I'm not sure about what language would have the longest string but we can at least test it in English. Assuming we always shorten the month to three characters it the longest would be: MMM DD, YYYY, HH:MM AM I get that to 22 chars, that is what is shown in the screenshot above. The wrapping problem appears with strings that have 21 chars, but with 20 it fits...
,
Sep 22 2017
memo: It's formatted with Intl.DateTimeFormat . https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat/format The object is constructed here. https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/ui/file_metadata_formatter.js?type=cs&q=fileMetadataFormatter&sq=package:chromium&l=24
,
Sep 25 2017
Maria, I think we could shrink the font size to fit the string into the limited space. WDYT? My proposal is to have a enough space for English text to fit in with preferred font size, and possibly change the font size for other languages.
,
Sep 25 2017
Let's definitely make sure it fits for English with the original font size. Would it work with Sebastien's suggestion to reduce the left padding? If my calculations are right we only need to fit two more characters. Hopefully this format should cover most (at least roman?) languages. The only thing I can see going over is abbreviations of the month. For other languages I don't know what we do if the . Reducing the font sounds dicey with readability. Sebastien - do you have thoughts?
,
Sep 26 2017
The style used for the metadata values was, as I checked in developer console, font-size: 12.96px, and font: Roboto. I extracted possible language tags (attached tags.txt) from the Language Subtag Registry [1]. With that we can technically compute the maximum possible width in px. Will it be worth doing from UI's point of view? [1] https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry.
,
Sep 26 2017
Oh how cool! Yes, if it's not too much effort I think it would be worth doing the computation so we get a better picture of what our worst-case scenario is.
,
Nov 16 2017
,
Dec 8 2017
,
Jan 30 2018
,
Feb 5 2018
,
Feb 6 2018
,
Feb 9 2018
The current layout has | 32 left pad | 96 label | 32 mid pad | 128 value | 32 right pad| total = 320 I think the 32 left pad should not be changed since it is the most noticeable and keeps the whole information box looking consistent with the rest of the UI. However the mid pad and right pad has plenty of scope for reduction without being noticeable. I'll start by dropping each to 16 and then I have an extra 32 for the value which can come up to 160. This is wide enough for English, and will also help any other language.
,
Feb 13 2018
Re: #17 SGTM!
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab4392b2386796ddc709e543c8337ceaf9e377f5 commit ab4392b2386796ddc709e543c8337ceaf9e377f5 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Feb 13 09:07:00 2018 Reduce QuickView files-metadata-entry mid and right pad to stop mod time wrap Changed middle and right padding from 32px to 16px. Value can now increase by 32px from 128px to 160px. Left padding stays at 32px which is consistent with the rest of the UI. Value is now wide enough to hold typical English Modified Time string "Aug 24, 2017, 10:30 AM" without wrapping. Will also help any other language with long strings. Bug: 640135 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I68c2f907027415cad375116ff376c83eec156425 Reviewed-on: https://chromium-review.googlesource.com/910750 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#536304} [modify] https://crrev.com/ab4392b2386796ddc709e543c8337ceaf9e377f5/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html
,
Feb 14 2018
Screenshot with middle and right padding reduced from 32px to 16.
,
Feb 16 2018
<files-triage>
,
Feb 23 2018
AM/PM is missing in preview. Google Chrome 66.0.3352.0 (Official Build) dev (64-bit) Platform 10431.0.0 (Official Build) dev-channel eve
,
Feb 26 2018
It looks like you are using 24-hour time (Settings > Advanced > Date and time > Use 24-hour clock. Turn this setting off and it should show AM/PM. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by oka@chromium.org
, Aug 24 2016