Issue metadata
Sign in to add a comment
|
Regression - [Mac][MaterialDesign] First bookmark icon in the BMB has 4 pt too much padding on the left side |
||||||||||||||||||||
Issue descriptionVersion: Chrome 54.0.2837.0 canary (64-bit) OS: Mac OS 10.11.6 What steps will reproduce the problem? (1) Take a look at the left side of the first bookmark icon in the Bookmarks Bar. What is the expected output? From the specs in issue 631275 it should be 12pt space between window border and first icon (like all other bookmarks 12pt from end of textbox to icon). What do you see instead? But I noticed 12pt space until the hover button and 16pt space until the favicon. This effects only the first bookmark. The space between all other bookmarks (from end of textbox to icon) is correct with 12pt. Please use labels and text to provide additional information. A screenshot is attached. Please feel free to close this issue if we can live with it. Thanks :-) Mehmet
,
Aug 26 2016
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfdafc14e9271e2d671bb5d4dd22de3d8067c9a6 commit dfdafc14e9271e2d671bb5d4dd22de3d8067c9a6 Author: shrike <shrike@chromium.org> Date: Tue Aug 30 04:57:34 2016 [Mac][Material Design] Fix indentation of first and last bookmark items. A recent cl that adjusted bookmark bar layout changed the left and right bookmark item indent to an incorrect value. This cl corrects that mistake. R=avi@chromium.org BUG= 640134 Review-Url: https://codereview.chromium.org/2293593002 Cr-Commit-Position: refs/heads/master@{#415125} [modify] https://crrev.com/dfdafc14e9271e2d671bb5d4dd22de3d8067c9a6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
Aug 31 2016
Fix confirmed on Canary. Requesting merge to M54.
,
Aug 31 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d2d3e88963eaef6edc1700aacf4c6bff9ed5c5f commit 2d2d3e88963eaef6edc1700aacf4c6bff9ed5c5f Author: Jayson Adams <shrike@chromium.org> Date: Wed Aug 31 17:55:59 2016 [Mac][Material Design] Fix indentation of first and last bookmark items. A recent cl that adjusted bookmark bar layout changed the left and right bookmark item indent to an incorrect value. This cl corrects that mistake. R=avi@chromium.org BUG= 640134 Review-Url: https://codereview.chromium.org/2293593002 Cr-Commit-Position: refs/heads/master@{#415125} (cherry picked from commit dfdafc14e9271e2d671bb5d4dd22de3d8067c9a6) Review URL: https://codereview.chromium.org/2295253002 . Cr-Commit-Position: refs/branch-heads/2840@{#74} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/2d2d3e88963eaef6edc1700aacf4c6bff9ed5c5f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
Aug 31 2016
,
Sep 1 2016
Tested the same on mac 10.11.6 chrome version 54.0.2840.8 - First bookmark icon indentation is fixed Please find the screenshots before and after fix. Hence adding TE-Verified labels
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d2d3e88963eaef6edc1700aacf4c6bff9ed5c5f commit 2d2d3e88963eaef6edc1700aacf4c6bff9ed5c5f Author: Jayson Adams <shrike@chromium.org> Date: Wed Aug 31 17:55:59 2016 [Mac][Material Design] Fix indentation of first and last bookmark items. A recent cl that adjusted bookmark bar layout changed the left and right bookmark item indent to an incorrect value. This cl corrects that mistake. R=avi@chromium.org BUG= 640134 Review-Url: https://codereview.chromium.org/2293593002 Cr-Commit-Position: refs/heads/master@{#415125} (cherry picked from commit dfdafc14e9271e2d671bb5d4dd22de3d8067c9a6) Review URL: https://codereview.chromium.org/2295253002 . Cr-Commit-Position: refs/branch-heads/2840@{#74} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/2d2d3e88963eaef6edc1700aacf4c6bff9ed5c5f/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Aug 23 201638.0 KB
38.0 KB View Download