Issue metadata
Sign in to add a comment
|
Regression: [Mac][MaterialDesign] Hover button of the Chevron Icon in the BMB is not centered |
||||||||||||||||||||
Issue descriptionVersion: Chrome 54.0.2837.0 canary (64-bit) OS: Mac OS 10.11.6 What steps will reproduce the problem? (1) Hover over the Chevron icon in the Bookmarks Bar What is the expected output? A centered hover button. What do you see instead? The hover button is not centered. Please see the attached screenshot. Please use labels and text to provide additional information. This is a regression from latest BMB tweaks https://codereview.chromium.org/2200303004 Thanks Mehmet
,
Sep 1 2016
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68058edebdc748f9df588a218ddce7fb90aa7635 commit 68058edebdc748f9df588a218ddce7fb90aa7635 Author: shrike <shrike@chromium.org> Date: Thu Sep 01 19:29:30 2016 [Mac][Material Design] Fix regression in position of chevron icon. Fixes a regression with the chevron-overflow button caused by a recent cl that adjusted the location of bookmark button icons where there is no title title. R=avi@chromium.org BUG= 640131 Review-Url: https://codereview.chromium.org/2304643002 Cr-Commit-Position: refs/heads/master@{#416016} [modify] https://crrev.com/68058edebdc748f9df588a218ddce7fb90aa7635/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
,
Sep 6 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96c3ac9152a0cccbef4f0777ea806d8fa5a243cd commit 96c3ac9152a0cccbef4f0777ea806d8fa5a243cd Author: Jayson Adams <shrike@chromium.org> Date: Tue Sep 06 22:29:06 2016 [Mac][Material Design] Fix regression in position of chevron icon. Fixes a regression with the chevron-overflow button caused by a recent cl that adjusted the location of bookmark button icons where there is no title. R=avi@chromium.org BUG= 640131 Review-Url: https://codereview.chromium.org/2304643002 Cr-Commit-Position: refs/heads/master@{#416016} (cherry picked from commit 68058edebdc748f9df588a218ddce7fb90aa7635) Review URL: https://codereview.chromium.org/2315933002 . Cr-Commit-Position: refs/branch-heads/2840@{#186} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/96c3ac9152a0cccbef4f0777ea806d8fa5a243cd/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
,
Sep 6 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96c3ac9152a0cccbef4f0777ea806d8fa5a243cd commit 96c3ac9152a0cccbef4f0777ea806d8fa5a243cd Author: Jayson Adams <shrike@chromium.org> Date: Tue Sep 06 22:29:06 2016 [Mac][Material Design] Fix regression in position of chevron icon. Fixes a regression with the chevron-overflow button caused by a recent cl that adjusted the location of bookmark button icons where there is no title. R=avi@chromium.org BUG= 640131 Review-Url: https://codereview.chromium.org/2304643002 Cr-Commit-Position: refs/heads/master@{#416016} (cherry picked from commit 68058edebdc748f9df588a218ddce7fb90aa7635) Review URL: https://codereview.chromium.org/2315933002 . Cr-Commit-Position: refs/branch-heads/2840@{#186} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/96c3ac9152a0cccbef4f0777ea806d8fa5a243cd/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Aug 23 2016