Regression : On pressing Tab key, buttons on downloads toolbar flickers.
Reported by
yfulgaon...@etouch.net,
Aug 23 2016
|
||||||
Issue descriptionChrome Version : 54.0.2837.0 (Official Build) a29577e8b1ed329373d426e85f679dfeb07a2979-refs/heads/master@{#413618} (64-bit) OS: Mac(10.10.5)(10.11.5), Linux(14.04. LTS), Windows(7,8,10) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://downloads and press Cmd S to save the page. 2. Now reload the page, hit Tab key and observe the ‘Clear all’ and ‘Open downloads..’ buttons on downloads toolbar. Actual : On pressing Tab key, buttons on downloads toolbar flickers. Expected : On pressing Tab key, buttons should not flicker. This is a regression issue broken in M-54, below is the Manual Regression and Narrow Bisect info. Good build: 54.0.2830.0 Bad build: 54.0.2831.0 Narrow Bisect : https://chromium.googlesource.com/chromium/src/+log/3b55735a3115817131690dc0607a6f998de23717..7f781f34f09fe2f3c5117f71de47e38d9bb59bad?pretty=fuller&n=10000 Suspecting: r412389 or 412396 ? from narrow bisect
,
Aug 23 2016
This looks like a custom properties regression. The roboto-bold.woff2 font is no longer loaded ahead-of-time for some reason, so the text flickers while it loads in. The same thing is visible in the toolbar of the history page.
,
Aug 24 2016
,
Aug 24 2016
,
Aug 25 2016
With MD Downloads switching to use <cr-toolbar>, this no longer affects M54. We'll still want to fix it for History in 55.
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19579a56f727f6577f2f97fb71fd2c1224f2c692 commit 19579a56f727f6577f2f97fb71fd2c1224f2c692 Author: dbeam <dbeam@chromium.org> Date: Thu Sep 22 18:22:06 2016 MD Downloads: hack to fix font flicker bug This renders a tiny bit of bold-weighted Roboto off screen so that the first time users hit bold Roboto (i.e. with keyboard focus on PAUSE/CANCEL/RESUME buttons) it doesn't flicker. BUG= 640121 , 648522 R=tsergeant@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2361733002 Cr-Commit-Position: refs/heads/master@{#420400} [modify] https://crrev.com/19579a56f727f6577f2f97fb71fd2c1224f2c692/chrome/browser/resources/md_downloads/downloads.html [modify] https://crrev.com/19579a56f727f6577f2f97fb71fd2c1224f2c692/chrome/browser/resources/md_downloads/vulcanized.html
,
Sep 22 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ranjitkan@chromium.org
, Aug 23 2016