New issue
Advanced search Search tips

Issue 640107 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Sep 2016
Cc:
hbos@chromium.org
jansson@chromium.org
webrtc-testing@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Browser tests for getStats

Project Member Reported by kjellander@chromium.org, Aug 23 2016 
Chris, I was wondering if it's possible to build some integration test that would automatically find errors like  bug 632457 ?

It seems like using a page like https://webrtc.github.io/samples/src/content/peerconnection/audio/ with a WebDriver test and then just checking for JS errors should be a reasonably easy test to implement?

Comment 1 by jansson@chromium.org, Aug 31 2016

Status: WontFix (was: Assigned)
We do have a test for that page https://github.com/webrtc/samples/blob/gh-pages/src/content/peerconnection/audio/js/test.js but the issue here is that it's run on GitHub commits, not when a new browser version is released hence several days can go past. The issue here was a Chrome getStats bug that caused this which was then fixed in Chrome. 

IMHO this should have been caught in a browser test in Chrome.

Comment 2 by kjellander@chromium.org, Aug 31 2016

Cc: jansson@chromium.org
Owner: ----
Status: Available (was: WontFix)
Right, but then I think we should use this bug for tracking the implementation of such a browser test.

Comment 3 by jansson@chromium.org, Aug 31 2016

Cc: hbos@chromium.org
Labels: MissingTests
Summary: Browser tests for getStats (was: Integration tests for WebRTC sample pages)
Then we need to be more specific, come to think of it, I think hbos@ did add some layout tests when he fixed this.

Comment 4 by hbos@chromium.org, Sep 1 2016

Status: Fixed (was: Available)
Yes, I already added a test that made sure a "nonsense" parameter would not cause a TypeError when I fixed that bug, i.e. that would catch this problem in the future.

Comment 5 by hbos@chromium.org, Sep 1 2016 

Note: There's a lot more work surrounding stats (master  bug 627816 ) which will require a lot more testing, but that is tracked by those bugs.

Comment 6 by jansson@chromium.org, Sep 1 2016

Labels: -MissingTests
►

Sign in to add a comment