New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640106 link

Starred by 3 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blue focus highlight on bookmarks bar is seen misplaced.

Reported by yfulgaon...@etouch.net, Aug 23 2016 
Chrome Version : 54.0.2837.0 (Official Build) a29577e8b1ed329373d426e85f679dfeb07a2979-refs/heads/master@{#413618} (64-bit)
OS: Mac(10.10.5)(10.11.5)

What steps will reproduce the problem?
1. Launch chrome and open NTP.
2. Press Tab key until focus move to ‘Apps’ shortcut, observe the focus.

Actual : Blue focus highlight on bookmark bar is seen misplaced.
Expected : Blue focus highlight on bookmark bar should be seen properly.

This is a regression issue broken in M-54, below is the Manual Regression and will soon update other info.
Good build: 54.0.2836.0
Bad build: 54.0.2837.0
Actual_focus.mov
2.1 MB Download

Comment 1 by yfulgaon...@etouch.net, Aug 23 2016

Components: UI>Browser>Bookmarks
Labels: hasbisect
Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect : 
https://chromium.googlesource.com/chromium/src/+log/06ed71dfa04dd2cd44a4802630ddf192312ea61a..83db57815bc84d57d03aa2b2d99d14c00426454f?pretty=fuller&n=10000

Suspecting: r413593 from narrow bisect.

Note : This is Mac specific issue and not seen on Windows and Linux OS.
Act_Exp_focus.png
56.4 KB View Download

Comment 2 by ranjitkan@chromium.org, Aug 23 2016

Labels: ReleaseBlock-Stable
Adding Release block label, please undo if not the case.

Comment 3 by ajha@chromium.org, Aug 26 2016 

shrike@: Could you please take a look at this.

Comment 4 by ajha@chromium.org, Sep 1 2016 

shrike@: Please take a look at this and review the blocker label.

Appreciate your help!

Comment 5 by shrike@chromium.org, Sep 1 2016

Status: Started (was: Assigned)
Have most of a fix. Working to land and then will cherry-pick back.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee1b55d9a6b0dfb066bab62ec24a1357a8794cde

commit ee1b55d9a6b0dfb066bab62ec24a1357a8794cde
Author: shrike <shrike@chromium.org>
Date: Thu Sep 01 19:38:55 2016

[Mac][Material Design] Adjust focus ring position of bookmark bar items.

This cl fixes a regression caused by a recent cl that adjusted bookmark
bar item metrics. Those changes threw off the positioning of the focus
ring highlights.

R=avi@chromium.org
BUG= 640106 

Review-Url: https://codereview.chromium.org/2299803003
Cr-Commit-Position: refs/heads/master@{#416018}

[modify] https://crrev.com/ee1b55d9a6b0dfb066bab62ec24a1357a8794cde/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

Comment 7 by shrike@chromium.org, Sep 6 2016

Labels: Merge-Request-54
Fix verified on Canary. Requesting merge to M54.
Screen Shot 2016-09-06 at 3.21.05 PM.png
10.9 KB View Download

Comment 8 by dimu@chromium.org, Sep 6 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 6 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b94adffc1bedcf86fc375c18d233d5b9f3a1ea29

commit b94adffc1bedcf86fc375c18d233d5b9f3a1ea29
Author: Jayson Adams <shrike@chromium.org>
Date: Tue Sep 06 22:35:40 2016

[Mac][Material Design] Adjust focus ring position of bookmark bar items.

This cl fixes a regression caused by a recent cl that adjusted bookmark
bar item metrics. Those changes threw off the positioning of the focus
ring highlights.

R=avi@chromium.org
BUG= 640106 

Review-Url: https://codereview.chromium.org/2299803003
Cr-Commit-Position: refs/heads/master@{#416018}
(cherry picked from commit ee1b55d9a6b0dfb066bab62ec24a1357a8794cde)

Review URL: https://codereview.chromium.org/2313113002 .

Cr-Commit-Position: refs/branch-heads/2840@{#188}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/b94adffc1bedcf86fc375c18d233d5b9f3a1ea29/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

Comment 10 by shrike@chromium.org, Sep 6 2016

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b94adffc1bedcf86fc375c18d233d5b9f3a1ea29

commit b94adffc1bedcf86fc375c18d233d5b9f3a1ea29
Author: Jayson Adams <shrike@chromium.org>
Date: Tue Sep 06 22:35:40 2016

[Mac][Material Design] Adjust focus ring position of bookmark bar items.

This cl fixes a regression caused by a recent cl that adjusted bookmark
bar item metrics. Those changes threw off the positioning of the focus
ring highlights.

R=avi@chromium.org
BUG= 640106 

Review-Url: https://codereview.chromium.org/2299803003
Cr-Commit-Position: refs/heads/master@{#416018}
(cherry picked from commit ee1b55d9a6b0dfb066bab62ec24a1357a8794cde)

Review URL: https://codereview.chromium.org/2313113002 .

Cr-Commit-Position: refs/branch-heads/2840@{#188}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/b94adffc1bedcf86fc375c18d233d5b9f3a1ea29/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

Comment 12 by benhenry@chromium.org, Sep 29 2017

Components: Blink>HTML>Focus

Comment 13 by benhenry@chromium.org, Sep 29 2017

Components: -Blink>Focus
►

Sign in to add a comment