New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640100 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Side bar displayed on incorrect side in RTL languages

Reported by dmascare...@etouch.net, Aug 23 2016

Issue description

Version:54.0.2837.0 (Official Build) a29577e8b1ed329373d426e85f679dfeb07a2979-refs/heads/master@{#413618} 32/64 bit
OS: Windows (7,8,10)

Pre-condition: Change the browser language to 'Arabic'.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://history/
2. Observe the main menu toolbar of the history page.

Actual: Main menu toolbar of history page is seen at L.H.S of the page instead of R.H.S.
Expected:Main menu toolbar of history page should be seen at R.H.S of the page.

This is regression issue, broken in 'M 54' and below is narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/4dab74137593abb0888e415294aeb80da27362e3..0adaed21be3234480594612cae9dc3e4d8c3c0c6?pretty=fuller&n=1000

Suspecting: r408572

Good build:54.0.2811.0
Bad build:54.0.2812.0

Note: Issue is not seen on Mac and Linux OS.


 
Actual.png
95.7 KB View Download
Expected.png
96.3 KB View Download
Labels: ReleaseBlock-Beta
Adding release block label, please undo if not the case.
Status: Started (was: Assigned)
Summary: Regression: Side bar displayed on incorrect side in RTL languages (was: Regression:Weird UI for chrome://history page is seen after changing the browser language to 'Arabic'.)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80d506d4e1869754c9f119a32943658153140571

commit 80d506d4e1869754c9f119a32943658153140571
Author: dbeam <dbeam@chromium.org>
Date: Tue Aug 23 23:26:46 2016

MD History: fix side nav layout in RTL

R=tsergeant@chromium.org
BUG= 640100 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2268353004
Cr-Commit-Position: refs/heads/master@{#413896}

[modify] https://crrev.com/80d506d4e1869754c9f119a32943658153140571/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/80d506d4e1869754c9f119a32943658153140571/chrome/browser/resources/md_history/app.vulcanized.html

Status: Fixed (was: Started)

Sign in to add a comment