New issue
Advanced search Search tips

Issue 640092 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

MD settings: all dialogs should be 512px wide

Project Member Reported by bettes@chromium.org, Aug 23 2016

Issue description

Expected width: 512px
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_dialogs.png%3Fz=width
 
Screen Shot 2016-08-22 at 10.42.20 PM.png
38.3 KB View Download
Components: -UI>Browser>History UI>Settings

Comment 2 by dbeam@chromium.org, Aug 29 2016

Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by dpa...@chromium.org, Sep 14 2016

Cc: dpa...@chromium.org
Labels: Needs-Feedback
Owner: bettes@chromium.org
@bettes: The dialog spec mentions 512px only for min-width, but it does not mention anything for max-width. Is this a spec change that should be applied to all dialogs? Then this is not just for the reset dialog, for example here are two more dialogs that are wider than 512px http://imgur.com/a/b2Adg (535px and 560px).

Regarding the reset dialog itself, making it max-width of 512px causes the "View reported settings" link to wrap around in a weird way, see http://imgur.com/a/EPxvF. Is that OK?
Cc: bettes@chromium.org
 Issue 619766  has been merged into this issue.

Comment 5 by dbeam@chromium.org, Jan 6 2017

Blocking: 671375
Cc: -bettes@chromium.org dbeam@chromium.org
Labels: Hotlist-MD-Settings-Reset Hotlist-MD-Settings-General OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: dpa...@chromium.org
You can consider 512px to be a fixed dialog width for all settings related UIs, so it should apply to all the UIs in question. 

For the reset dialog, the screenshot shows some additional concerns: 

1. update width to 512px
2. all text links should use google blue 700 and no text decoration
3. Shorten footer string to be: "Make Chrome better by reporting current settings. View report"
4. Update footer style to be white with 1px #000 rule line (same as CBD)
5. Ensure there's 16px of padding below and above the footer string. If text overflows to a second line, the rule should still apply. The text should also respect the left-indention and be left-aligned to the text, not the checkbox. 

Updated mock: 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Reset.png%3Fz=width

Comment 7 by dbeam@chromium.org, Jan 10 2017

Cc: mahmadi@chromium.org tommycli@chromium.org
 Issue 640090  has been merged into this issue.

Comment 8 by dbeam@chromium.org, Jan 10 2017

Cc: -dbeam@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Assigned)
Summary: All dialogs in MD settings should be 512px (was: Reset dialog is the wrong size)

Comment 9 by dbeam@chromium.org, Jan 10 2017

Summary: MD settings: all dialogs should be 512px wide (was: All dialogs in MD settings should be 512px)
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e75e2c17355305e719485d68c027f9aac7eaf9

commit 70e75e2c17355305e719485d68c027f9aac7eaf9
Author: dbeam <dbeam@chromium.org>
Date: Tue Jan 10 19:14:19 2017

MD WebUI: change all <dialog is="cr-dialog"> to 512px width

This should narrow some dialogs in settings, and have no functional
affect on history.

R=dpapad@chromium.org
BUG= 640092 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2623673003
Cr-Commit-Position: refs/heads/master@{#442649}

[modify] https://crrev.com/70e75e2c17355305e719485d68c027f9aac7eaf9/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/70e75e2c17355305e719485d68c027f9aac7eaf9/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/70e75e2c17355305e719485d68c027f9aac7eaf9/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/70e75e2c17355305e719485d68c027f9aac7eaf9/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html
[modify] https://crrev.com/70e75e2c17355305e719485d68c027f9aac7eaf9/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[modify] https://crrev.com/70e75e2c17355305e719485d68c027f9aac7eaf9/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/70e75e2c17355305e719485d68c027f9aac7eaf9/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Comment 11 by dbeam@chromium.org, Jan 10 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment