New issue
Advanced search Search tips

Issue 640086 link

Starred by 2 users
Status: Archived
Owner:
mattreynolds@chromium.org
Closed: Apr 2017
Cc:
bajones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

GamepadProviderTest.Sanitization is flaky on ChromeOS MSAN

Project Member Reported by thestig@chromium.org, Aug 23 2016 
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20ChromeOS%20MSan%20Tests/builds/590
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20ChromeOS%20MSan%20Tests/builds/517
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20ChromeOS%20MSan%20Tests/builds/509
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20ChromeOS%20MSan%20Tests/builds/495
etc...

GamepadProviderTest.Sanitization (run #1):
[ RUN      ] GamepadProviderTest.Sanitization
../../device/gamepad/gamepad_provider_unittest.cc:198: Failure
Value of: output->length
  Actual: 0
Expected: 1u
Which is: 1
../../device/gamepad/gamepad_provider_unittest.cc:199: Failure
Value of: output->items[0].buttonsLength
  Actual: 0
Expected: 1u
Which is: 1
../../device/gamepad/gamepad_provider_unittest.cc:202: Failure
Value of: output->items[0].axesLength
  Actual: 0
Expected: 1u
Which is: 1
[  FAILED  ] GamepadProviderTest.Sanitization (87 ms)


GamepadProviderTest.Sanitization (run #2):
[ RUN      ] GamepadProviderTest.Sanitization
../../device/gamepad/gamepad_provider_unittest.cc:198: Failure
Value of: output->length
  Actual: 1
Expected: 1u
Which is: 1
[  FAILED  ] GamepadProviderTest.Sanitization (86 ms)

...
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c06c4b64d9422535d6a3b33a7a98f47cf1c283

commit 97c06c4b64d9422535d6a3b33a7a98f47cf1c283
Author: thestig <thestig@chromium.org>
Date: Tue Aug 23 05:47:37 2016

MSAN: Mark GamepadProviderTest.Sanitization as flaky.

BUG= 640086 
TBR=bajones@chromium.org

Review-Url: https://codereview.chromium.org/2271563002
Cr-Commit-Position: refs/heads/master@{#413673}

[modify] https://crrev.com/97c06c4b64d9422535d6a3b33a7a98f47cf1c283/device/gamepad/gamepad_provider_unittest.cc

Comment 2 by mattreynolds@chromium.org, Apr 4 2017

Status: Available (was: Untriaged)

Comment 3 by mattreynolds@chromium.org, Apr 14 2017

Owner: mattreynolds@chromium.org
Status: Fixed (was: Available)
This looks identical to failures in other flaky GamepadProviderTest unittests:

 crbug.com/692219  - GamepadProviderTest.ConnectDisconnectMultiple
 crbug.com/702712  - GamepadProviderTest.Sanitization (possible dupe?)
 crbug.com/705367  - GamepadProviderTest.PollingAccess

I believe this race condition (now fixed) is the cause of these flakes:

https://codereview.chromium.org/2820563003

I'm marking this as Fixed and have re-enabled the test on all platforms. Please reopen if the test is still flaky!

Comment 4 by reillyg@chromium.org, Apr 27 2017

Components: -IO>Gamepad Blink>GamepadAPI

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment