New issue
Advanced search Search tips

Issue 640068 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
M-X

Blocking:
issue 454835


Show other hotlists

Hotlists containing this issue:
MacViews-Task-Queue


Sign in to add a comment

Mac: Failing tests in render_text_unittest.cc with RenderTextHarfbuzz.

Project Member Reported by karandeepb@chromium.org, Aug 23 2016

Issue description

Version: 54.0.2831.0
OS: Mac

When all the tests in render_text_unittest.cc are run with RenderTextHarfBuzz on Mac, the following tests fail:-

1 test failed:
    RenderTextTest.TextDoesntClip (../../ui/gfx/render_text_unittest.cc:3402)
3 tests crashed:
    RenderTextTest.ElidedObscuredText (../../ui/gfx/render_text_unittest.cc:771)
    RenderTextTest.ElidedText (../../ui/gfx/render_text_unittest.cc:691)
    RenderTextTest.MoveCursorLeftRight_MeiryoUILigatures (../../ui/gfx/render_text_unittest.cc:1422)



 
Blocking: 454835
Labels: MacViews-Cleanup
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3af00bdb89c68853a0040d507a048c79396d00d9

commit 3af00bdb89c68853a0040d507a048c79396d00d9
Author: Ben Wagner <bungeman@chromium.org>
Date: Wed Oct 25 19:01:52 2017

RenderText to consider style for bounds.

This fixes a long standing TODO to account for stylized baselines in
string sizing. This appears to be the cause of a number of confusing
work-arounds in the RenderTextTest.TextDoesntClip/HarfBuzz test. This
test checks that text draws inside the calculated bounds, but these
calculated bounds do not take into account the fake super and
subscripting RenderText allows. As a result, this test only passed in
the past by accident, the fake super and subscripts just happened to
barely squeeze into the base font's bounds.

BUG= skia:6931 , chromium:459812 , chromium:624513 , chromium:640068 

Change-Id: I224a1e9526f04525ac8581819ad60bd9f90ffa0e
Reviewed-on: https://chromium-review.googlesource.com/735783
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511542}
[modify] https://crrev.com/3af00bdb89c68853a0040d507a048c79396d00d9/ui/gfx/render_text_harfbuzz.cc
[modify] https://crrev.com/3af00bdb89c68853a0040d507a048c79396d00d9/ui/gfx/render_text_unittest.cc

RenderTextTest.TextDoesntClip has been re-enabled and hopefully the underlying issue has been fixed. At least RenderTextTest.ElidedObscuredText and RenderTextTest.ElidedText are still disabled on Mac, so this report is only partially fixed.
Labels: M-X
Owner: ellyjo...@chromium.org
Status: Started (was: Available)
Good news - these seem to work now. https://chromium-review.googlesource.com/c/chromium/src/+/986538
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2511d3114080eb5d01736d0037b06d3f32b3b71e

commit 2511d3114080eb5d01736d0037b06d3f32b3b71e
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Mar 29 20:38:28 2018

gfx: re-enable some RenderText tests on Mac

These tests were broken a while ago, but seem to have been fixed.

Bug:  640068 
Change-Id: Ic69c9736e6a5999dba2d3aee6bc00c30a1f7a7ce
Reviewed-on: https://chromium-review.googlesource.com/986538
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546935}
[modify] https://crrev.com/2511d3114080eb5d01736d0037b06d3f32b3b71e/ui/gfx/render_text_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment