New issue
Advanced search Search tips

Issue 640060 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

chromium-checkins@ doesn't receive emails about git commits from commitsentry

Project Member Reported by tkent@chromium.org, Aug 23 2016

Issue description

See https://groups.google.com/a/chromium.org/forum/#!forum/chromium-checkins
No new commit notifications after August 20.

Very similar to Issue 561094.

 

Comment 1 by mmoss@chromium.org, Aug 23 2016

Components: -Infra>Labs Infra
Labels: Infra-Troopers
FYI, unless you strongly suspect a hardware/network issue, this should really go through the Trooper queue (label Infra-Troopers). Troopers can pass it off to Labs if it appears to be their issue (e.g. no email is going out anywhere, indicating the smtp gateway is down or something), which doesn't look like the case here.

Comment 2 by mmoss@chromium.org, Aug 23 2016

The log is full of exceptions:

2016-08-23 13:46:07,782 - chromium - ERROR - Uncaught Exception in <chrome.bugdroid.poller_handlers.SentryPollerHandler object at 0x7f9738e1d610>
Traceback (most recent call last):
  File "/usr/local/google/home/chrome-cron/src/infra/infra_internal/py_issue_tracker/chrome/bugdroid/gitiles_poller.py", line 176, in _ProcessGitLogEntry
    handler.ProcessLogEntry(log_entry)
  File "/usr/local/google/home/chrome-cron/src/infra/infra_internal/py_issue_tracker/chrome/bugdroid/poller_handlers.py", line 134, in ProcessLogEntry
    default_to_project=True)
TypeError: get_issues() got an unexpected keyword argument 'project'

Comment 3 by mmoss@chromium.org, Aug 23 2016

Oh, wait, #2 is a different problem (commitsentry). Yay for finding more bugs.

Comment 4 by mmoss@chromium.org, Aug 23 2016

Owner: aga...@chromium.org
Status: Assigned (was: Untriaged)
Restarting commitsentry fixed chromium-checkins.

Assigning to agable for the error in #2, which appears to be related to https://chrome-internal.googlesource.com/infra/infra_internal/+/a87fa0185df064862ad9e4448b80fe99bdd5dbff

Comment 5 by aga...@chromium.org, Aug 23 2016

Status: Started (was: Assigned)
https://chromereviews.googleplex.com/494997013

Not sure how these callsites were missed, nor how restarting it fixed anything??

Comment 6 by mmoss@chromium.org, Aug 23 2016

Restarting didn't fix these broken calls, it just fixed sending the chromium-checkins emails, which is confusingly intertwined, yet somehow separate, from the sentry processing. These should probably be two completely separate tools, but "legacy", "technical debt", yada-yada.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/0e9c125674510bef3e983cf681f962fa5f05664d

commit 0e9c125674510bef3e983cf681f962fa5f05664d
Author: agable <agable@google.com>
Date: Tue Aug 23 18:24:46 2016

Comment 8 by aga...@chromium.org, Aug 23 2016

Status: Fixed (was: Started)
CL has been deployed.

Sign in to add a comment