New issue
Advanced search Search tips

Issue 640059 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Remoting Android] Remove Synchronizations on RenderData

Project Member Reported by yuweih@chromium.org, Aug 23 2016

Issue description

Previously RenderData was used on both the UI thread and the display thread so we need to synchronize RenderData to ensure thread safety.

The new OpenGL renderer doesn't expose the display thread to Java so RenderData will not be used on a non-UI thread. After the removal of the old renderer, it is safe to remove synchronizations on RenderData.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633

commit ebd382690bf3ea3c8b550c3ce3eaae1d083a3633
Author: yuweih <yuweih@chromium.org>
Date: Tue Aug 23 22:56:34 2016

[Remoting Android] Remove Synchronizations on RenderData

The new OpenGL renderer doesn't expose the display thread to Java so RenderData
won't be used on a non-UI thread. After the removal of the old renderer, it is
safe to remove all those synchronizations on RenderData.

BUG= 640059 

Review-Url: https://codereview.chromium.org/2272483002
Cr-Commit-Position: refs/heads/master@{#413880}

[modify] https://crrev.com/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633/remoting/android/java/src/org/chromium/chromoting/RenderData.java
[modify] https://crrev.com/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
[modify] https://crrev.com/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java
[modify] https://crrev.com/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633/remoting/android/java/src/org/chromium/chromoting/TouchInputStrategy.java
[modify] https://crrev.com/ebd382690bf3ea3c8b550c3ce3eaae1d083a3633/remoting/android/java/src/org/chromium/chromoting/TrackpadInputStrategy.java

Comment 2 by yuweih@chromium.org, Aug 24 2016

Status: Fixed (was: Assigned)

Sign in to add a comment