New issue
Advanced search Search tips

Issue 640058 link

Starred by 2 users
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Aug 2016
Cc:
valdrin@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 538245



Sign in to add a comment

MD Downloads: 'More actions...' menu opens in wrong direction in RTL

Project Member Reported by dbeam@chromium.org, Aug 23 2016 
with LANGUAGE={ar,he} (i.e. an RTL UI language) the downloads "More actions..." vertical dot menu opens in the wrong direction, off screen.  This basically makes the menu way less usable in RTL.

I added code to flip the direction:
https://codereview.chromium.org/1385113002/

Then, a few months later, Polymer added their own automagic flipping that reversed our logic:
https://github.com/PolymerElements/iron-fit-behavior/pull/38/

My change was there first :P.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fea3a25f631f9e86c37c4d0d7823733cb5b2fb3f

commit fea3a25f631f9e86c37c4d0d7823733cb5b2fb3f
Author: dbeam <dbeam@chromium.org>
Date: Tue Aug 23 03:34:25 2016

MD Downloads: fix 'More actions...' menu in RTL

Polymer's iron-fit-behavior flips these values for us since this PR:
https://github.com/PolymerElements/iron-fit-behavior/pull/38/

And because we're using dir="$i18n{textdirection}", it's guaranteed to
be correct at any time in the page's life cycle.

R=tsergeant@chromium.org
BUG= 640058 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2271513002
Cr-Commit-Position: refs/heads/master@{#413656}

[modify] https://crrev.com/fea3a25f631f9e86c37c4d0d7823733cb5b2fb3f/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/fea3a25f631f9e86c37c4d0d7823733cb5b2fb3f/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/fea3a25f631f9e86c37c4d0d7823733cb5b2fb3f/chrome/browser/resources/md_downloads/toolbar.js
[modify] https://crrev.com/fea3a25f631f9e86c37c4d0d7823733cb5b2fb3f/chrome/browser/resources/md_downloads/vulcanized.html

Comment 2 by dbeam@chromium.org, Aug 24 2016

Status: Fixed (was: Started)
►

Sign in to add a comment