New issue
Advanced search Search tips

Issue 640052 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Implement UMA that tracks Chrome’s total data usage

Project Member Reported by tbansal@chromium.org, Aug 23 2016

Issue description

Implement UMA that tracks Chrome’s total data usage. Having such a UMA can help us track data usage regressions in Chrome. It can also be used in A/B testing of an experiment that may affect Chrome's data usage.

On Android, the data usage can be measured either at lower socket layers using Android's TrafficStats APIs. Using TrafficStats API would also include the data from packet retransmissions etc.

On all other platforms, it can be measured within Chrome's NetworkActivityMonitor which is notified by all TCP and UDP sockets every time they read or write data.
 
I guess this is probably not needed.
We already have the following UMA.
TrafficStatsAmortizer.PreAmortizationRunDataUseBytes.Rx
TrafficStatsAmortizer.PreAmortizationRunDataUseBytes.Tx

For android we also have the post amortized bytes.
TrafficStatsAmortizer.PostAmortizationRunDataUseBytes.Rx
TrafficStatsAmortizer.PostAmortizationRunDataUseBytes.Tx
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21318e32a681bbb2ed20f15d7e34822b723ce616

commit 21318e32a681bbb2ed20f15d7e34822b723ce616
Author: tbansal <tbansal@chromium.org>
Date: Tue Aug 23 19:09:59 2016

Refactor the DataUseMeasurement class

Some of the methods in DataUseMeasurement class have been
renamed in this CL. This is in preparation of adding more
methods to this class.

This change also has a positive side-effect that it hides
the internal details of DataUseMeasurement class from
ChromeNetworkDelegate.

BUG= 640052 

Review-Url: https://codereview.chromium.org/2269833002
Cr-Commit-Position: refs/heads/master@{#413806}

[modify] https://crrev.com/21318e32a681bbb2ed20f15d7e34822b723ce616/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/21318e32a681bbb2ed20f15d7e34822b723ce616/chrome/browser/precache/precache_util.cc
[modify] https://crrev.com/21318e32a681bbb2ed20f15d7e34822b723ce616/components/data_use_measurement/content/data_use_measurement.cc
[modify] https://crrev.com/21318e32a681bbb2ed20f15d7e34822b723ce616/components/data_use_measurement/content/data_use_measurement.h
[modify] https://crrev.com/21318e32a681bbb2ed20f15d7e34822b723ce616/components/data_use_measurement/content/data_use_measurement_unittest.cc

Labels: M-55
Status: Fixed (was: Started)

Sign in to add a comment