New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 640043 link

Starred by 3 users
Status: Fixed
Owner:
█ nek...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
█ chaok@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

IAccessibleAction::name should not be localised

Project Member Reported by ja...@nvaccess.org, Aug 23 2016 
Version: 52.0.2743.116 m
OS: Windows 10 64 bit

The string returned by IAccessibleAction::name should *not* be localized, but it currently is. Note that there is IAccessibleAction::localizedName for the localized name, though Chrome doesn't currently implement this.

STR:
1. Start the NVDA screen reader.
2. Start Chrome with the following command line: chrome --lang=it
3. Open this URL: data:text/html,<div onClick=";">Test</div>
4. Ensure focus is in the document and press control+home, which will move to the top of the document and read the line.
Expected: NVDA should say "Test"
Actual: NVDA says "blank"

5. Open the NVDA Python console with NVDA+control+z.
6. Enter the following line: nav.IAccessibleActionObject.name(0)
Expected: u'click'
Actual: u'fai clic'

Impact: This breaks the NVDA screen reader for all nodes which have a click action when Chrome is set to a language other than English.
NVDA issue: https://github.com/nvaccess/nvda/issues/6249

Comment 1 by nek...@chromium.org, Nov 22 2016

Cc: dmazz...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e043304856897ee42289b94181baf34726f83c2

commit 6e043304856897ee42289b94181baf34726f83c2
Author: nektar <nektar@chromium.org>
Date: Wed Dec 14 22:21:59 2016

Moved action verbs out of Blink.

When Blink is asked to provide what actions an accessibility object supports, instead of returning a string with an action verb, it now returns a value from the |WebAXSupportedAction| enumeration.
This change allows different platforms to localize the actions in any way they please. More specifically, on Windows we now expose two APIs: one for returning the localized action verb and one that returns the verb in English. This is a requirement dictated by the IAccessible2 Spec.
BUG= 640043 
TESTED=By changing Chrome's language to something other than English and trying to read a clickable element with NVDA
R=dmazzoni@chromium.org, sky@chromium.org, avi@chromium.org

Review-Url: https://codereview.chromium.org/2518183002
Cr-Commit-Position: refs/heads/master@{#438649}

[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/app/strings/content_strings.grd
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/browser/accessibility/accessibility_tree_formatter_blink.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/browser/accessibility/browser_accessibility_auralinux.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/child/blink_platform_impl.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/renderer/accessibility/blink_ax_enum_conversion.h
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/content/test/data/accessibility/html/action-verbs-expected-blink.txt
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/third_party/WebKit/public/platform/WebLocalizedString.h
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/third_party/WebKit/public/web/WebAXObject.h
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/accessibility/BUILD.gn
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/accessibility/DEPS
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/accessibility/ax_text_utils.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/accessibility/ax_text_utils.h
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/accessibility/ax_tree_combiner.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/strings/ui_strings.grd
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/views/controls/button/button.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/views/controls/button/menu_button.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/views/controls/combobox/combobox.cc
[modify] https://crrev.com/6e043304856897ee42289b94181baf34726f83c2/ui/views/controls/textfield/textfield.cc

Comment 3 by nek...@chromium.org, Dec 14 2016

Status: Fixed (was: Started)
This behavior is also now fixed for Linux ATK. We still need to implement the localized version of the API for that platform.

Comment 4 by nek...@chromium.org, Dec 14 2016

Cc: chaok@chromium.org
►

Sign in to add a comment