Harmony [Mac] - Disable ripples in controls |
||
Issue descriptionPer slide 9 of https://docs.google.com/presentation/d/17CDjsa8u0rhgjV0zTCJMwY1z5BbaaXKiJqBL_N1s-9A/edit#slide=id.g160eef1b46_11_73 , ripples are not displayed in Harmony UI on the Mac. A gray fill is shown instead. We need to disable the ripple effect where it's used when running on the Mac.
,
Aug 23 2016
You should do what the current Mac Material Design toolbar buttons do: they fill with a gray on mouse over, and fill with a darker gray on click.
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44bfbfa71224fed7aeb43d942b503c69d6c192cf commit 44bfbfa71224fed7aeb43d942b503c69d6c192cf Author: ellyjones <ellyjones@chromium.org> Date: Fri Aug 26 21:56:21 2016 Harmony: disable ripples on Mac The Mac IxD doesn't use them. Instead, buttons have a separate pressed state which is defined in the Harmony spec. BUG= 640032 Review-Url: https://codereview.chromium.org/2270933002 Cr-Commit-Position: refs/heads/master@{#414825} [modify] https://crrev.com/44bfbfa71224fed7aeb43d942b503c69d6c192cf/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/44bfbfa71224fed7aeb43d942b503c69d6c192cf/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/44bfbfa71224fed7aeb43d942b503c69d6c192cf/ui/views/controls/button/md_text_button.h [modify] https://crrev.com/44bfbfa71224fed7aeb43d942b503c69d6c192cf/ui/views/style/platform_style.cc [modify] https://crrev.com/44bfbfa71224fed7aeb43d942b503c69d6c192cf/ui/views/style/platform_style.h [modify] https://crrev.com/44bfbfa71224fed7aeb43d942b503c69d6c192cf/ui/views/style/platform_style_mac.mm
,
Aug 29 2016
This is done now. shrike@, what do you think of the resulting look?
,
Aug 29 2016
This looks nice! Is it possible to add an MD blue button to this collection of buttons?
,
Aug 30 2016
#5: There's a blue button in views_examples_with_content_exe's 'button' example that shows the new behavior. Is that what you're looking for?
,
Aug 30 2016
Is it literally the "Blue Button" button (which is yellow for me - it must use an image asset)? Or the "Styled Button" button? The fact that there's a "Material design" button implies that the other buttons are not Material Design. Perhaps this part of the example should be reorganized to be more clear about what's being shown?
,
Aug 30 2016
Oh, I see! The buttons in that dialog are, in order: 1) Regular LabelButton (will be Shiny Modern on Mac, right now) 2) Styled LabelButton (same) 3) Disabled LabelButton 4) "Blue button" - a weird helper class. Dialogs that expect to be "MD" call MdTextButton::CreateSecondaryUiBlueButton(), which returns them a call-to-action MdButton if --secondary-ui-md is set, and a BlueButton if not. So I think this is the "pre-MD call-to-action" button type. 5) "Material design" - a regular MdButton 6) "Default" - a default MdButton 7) "Call to action" - a call-to-action MdButton 8) An image button (has an image of an X on it) The "Blue button" is pretty weird because it's drawn from images, and so is not affected by graphite at all. This change affects buttons 4, 5, 6, and 7.
,
Sep 7 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Aug 23 2016