New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640032 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony [Mac] - Disable ripples in controls

Project Member Reported by shrike@chromium.org, Aug 22 2016

Issue description

Per slide 9 of https://docs.google.com/presentation/d/17CDjsa8u0rhgjV0zTCJMwY1z5BbaaXKiJqBL_N1s-9A/edit#slide=id.g160eef1b46_11_73 , ripples are not displayed in Harmony UI on the Mac. A gray fill is shown instead. We need to disable the ripple effect where it's used when running on the Mac.

 
Status: Started (was: Assigned)
Disabling ripples in the Harmony controls is simple enough, but then there's no visual feedback whatsoever that the button has been pressed. Do we need to reintroduce a "pressed" state? The Harmony sticker sheets do not have such a state right now, so we'd want to work with UI to design one.

In any case, here's a WIP CL that just disables the ripples, so you can see what it looks like on Mac: https://codereview.chromium.org/2270933002

Comment 2 by shrike@chromium.org, Aug 23 2016

You should do what the current Mac Material Design toolbar buttons do: they fill with a gray on mouse over, and fill with a darker gray on click.

Status: Fixed (was: Started)
This is done now.

shrike@, what do you think of the resulting look?

Comment 5 by shrike@chromium.org, Aug 29 2016

This looks nice!

Is it possible to add an MD blue button to this collection of buttons?

#5: There's a blue button in views_examples_with_content_exe's 'button' example that shows the new behavior. Is that what you're looking for?

Comment 7 by shrike@chromium.org, Aug 30 2016

Is it literally the "Blue Button" button (which is yellow for me - it must use an image asset)? Or the "Styled Button" button?

The fact that there's a "Material design" button implies that the other buttons are not Material Design. Perhaps this part of the example should be reorganized to be more clear about what's being shown?
Oh, I see!

The buttons in that dialog are, in order:

1) Regular LabelButton (will be Shiny Modern on Mac, right now)
2) Styled LabelButton (same)
3) Disabled LabelButton
4) "Blue button" - a weird helper class. Dialogs that expect to be "MD" call MdTextButton::CreateSecondaryUiBlueButton(), which returns them a call-to-action MdButton if --secondary-ui-md is set, and a BlueButton if not. So I think this is the "pre-MD call-to-action" button type.
5) "Material design" - a regular MdButton
6) "Default" - a default MdButton
7) "Call to action" - a call-to-action MdButton
8) An image button (has an image of an X on it)

The "Blue button" is pretty weird because it's drawn from images, and so is not affected by graphite at all. This change affects buttons 4, 5, 6, and 7. 
Cc: bettes@chromium.org ellyjo...@chromium.org
 Issue 635153  has been merged into this issue.

Sign in to add a comment