New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 640012 link

Starred by 5 users

Issue metadata

Status: Verified
Merged: issue 639552
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

CJK candidate windows appear in wrong place when using multiple IMEs

Project Member Reported by songsuk@chromium.org, Aug 22 2016

Issue description

Chrome Version       : 54.0.2832.0
Platform             : 8730.0.0 - Candy


What steps will reproduce the problem?
(1)  open google docs(or spreadsheets/presentation)
(2)  enter "Testing ime" switch IME to Japanese 
(3)  switch IME to Japanese and enter "ka" 

If the issue doesn't show, then
4. enter "Testing ime"
5. switch IME to Korean and enter "hangul", 한글 
6. switch IME to Japanese and enter Japanese characters



What is the expected result? What happens instead?
On step#3/#6 Japanese candidate window appears wrong place(image_1.png, image2.png). 



Please provide any additional information below. Attach a screenshot if
possible.

 
image_1.png
293 KB View Download
image2.png
211 KB View Download
Owner: nona@chromium.org
Nona, this seems a dup to  issue 639552 , can you please take a look and confirm? Thanks.

Labels: OS-Windows
Summary: CJK candidate windows appear in wrong place when using multiple IMEs (was: CJK candidate windows appear in wrong place on Google Docs when using multiple IMEs)
ChromeOS: 
Able to reproduce the issue on any text field(except Omnibox/FindinPage) with Japanese IME. 
 
Seems Ko/Zh ime problem is due to Japanese IME.  Ko/Zh IMEs work properly before using Japanese IME. 

===================
Reproduce the issue on Chrome54.0.2837.0/Win7

Status: Assigned (was: Untriaged)

Comment 4 by yukawa@chromium.org, Aug 25 2016

Cc: aelias@chromium.org kinaba@chromium.org

Comment 5 by nona@chromium.org, Aug 29 2016

Mergedinto: 639552
Status: Duplicate (was: Assigned)

Comment 6 by nona@chromium.org, Sep 8 2016

Status: Started (was: Duplicate)
I'm sorry the fix in the 639552 is only for Mac OSX. This should be came from another reason.
Will take a look.
Labels: Needs-Bisect
Cc: ligim...@chromium.org
India team please run Bisect and update the bug.

Steps for win7 :
1. open google.com/translate
2. enable and set IME to Japanese (Hiragana)
3. on input field, enter "gakkou" and hit "Space" "Space" key, then able to see the candidate window. 
4. select any number and hit "enter" key to commit
5. hit "Space" "Space" "Space" key 
6. enter "gakkou" and hit "Space" "Space" key to see candidate window.  
The candidate window appears in wrong place (actualresult.png) 

Not reproduce on Chrome 53.0.2785.89
Reproduce the issue on Chrome54.0.2837.0/Win7
actualresult.png
60.4 KB View Download
expected.png
39.5 KB View Download

Comment 9 by nona@chromium.org, Sep 12 2016

Looks like this is regression from my chagne.
https://codereview.chromium.org/2121953002

I could reproduce this on Chrome OS canary.
This is not reproducible on Linux with Mozc.
Haven't tested on Windows.

I think I can start investigating the root cause.

I'm sorry for leaving a long time. I'm going to take a look.

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14f15f11744445a7adb34030719afeb41a9432d0

commit 14f15f11744445a7adb34030719afeb41a9432d0
Author: nona <nona@chromium.org>
Date: Wed Sep 14 05:35:59 2016

Fix invalid suggestion window position on ChromeOS and Windwos.

This is regression from
http://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b
The show_ime_if_needed is one shot message so we can't use it as a
trigger of monitoring composition bounding box, since we need
to keep monitoring during the text input session is active.

BUG= 640012 

Review-Url: https://codereview.chromium.org/2330423002
Cr-Commit-Position: refs/heads/master@{#418491}

[modify] https://crrev.com/14f15f11744445a7adb34030719afeb41a9432d0/content/browser/renderer_host/render_widget_host_view_aura.cc

Comment 11 by nona@chromium.org, Sep 14 2016

This should be now fixed. Will check it on next Windows Canary and if it works, I'm going to request merge approval.

Comment 12 by nona@chromium.org, Sep 14 2016

Labels: -Needs-Bisect
Labels: TE-Verified-55.0.2862.0 TE-Verified-M55
Verified the issue on Windows 10 using latest canary #55.0.2862.0 as per the comment #8
Observed that the fix is working as expected.

Attaching screencast for reference

Hence, adding the verified labels.
640012.mp4
568 KB View Download

Comment 14 by nona@chromium.org, Sep 20 2016

Labels: Merge-Request-54
Thank you for verifying! then, requesting merge approval for M54.

Comment 15 by dimu@chromium.org, Sep 20 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)

Comment 16 by nona@chromium.org, Sep 20 2016

Status: Fixed (was: Started)
The CL is merged. Closing...
Labels: -Merge-Approved-54
Thanks for the fix, confirming that the Cl is in M54 - Branch. 

https://chromium.googlesource.com/chromium/src.git/+/26e487a3d8add5a2c4e969565ac7c488c959d906

Removing Merge approved label.
Labels: merge-merged-2840
Labels: TE-Verified-54.0.2840.34 TE-Verified-M54
Verified the issue on Windows 10 using chrome beta version #54.0.2840.34 as per the comment #8
Observed that the fix is working as expected.

Attaching screencast for reference

Hence, adding the verified labels.
640012.mp4
809 KB View Download
Status: Verified (was: Fixed)
As per #13 and #19
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26e487a3d8add5a2c4e969565ac7c488c959d906

commit 26e487a3d8add5a2c4e969565ac7c488c959d906
Author: Seigo Nonaka <nona@google.com>
Date: Tue Sep 20 01:24:05 2016

Fix invalid suggestion window position on ChromeOS and Windwos.

This is regression from
http://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b
The show_ime_if_needed is one shot message so we can't use it as a
trigger of monitoring composition bounding box, since we need
to keep monitoring during the text input session is active.

BUG= 640012 

Review-Url: https://codereview.chromium.org/2330423002
Cr-Commit-Position: refs/heads/master@{#418491}
(cherry picked from commit 14f15f11744445a7adb34030719afeb41a9432d0)

Review URL: https://codereview.chromium.org/2353663004 .

Cr-Commit-Position: refs/branch-heads/2840@{#433}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/26e487a3d8add5a2c4e969565ac7c488c959d906/content/browser/renderer_host/render_widget_host_view_aura.cc

Sign in to add a comment