New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639977 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

PIN quick unlock: Seen Quick unlock screen on M53.

Project Member Reported by abod...@chromium.org, Aug 22 2016

Issue description

Google Chrome	53.0.2785.76 (Official Build) dev (32-bit)
Platform	8530.66.0 (Official Build) dev-channel 
Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Enable Quick unlock PIN on M54
(2) In another device install M53 and lock the device 

What is the expected output?
Should not be sync with M53.

What do you see instead?
Saw the same Quick unlock screen on M53 device too.


Please use labels and text to provide additional information.

 
IMG_20160822_152232.jpg
1.6 MB View Download
Owner: jdufault@chromium.org
Status: Assigned (was: Untriaged)
abodenha@ - do we want to merge a fix into m53? It'd probably be disabling PIN all-together or changing the pref name to some temporary non-synced value.

I think this is a reasonable WontFix because PIN is synced.
Cc: abodenha@chromium.org
+ abodenha@ see comment above
PIN unlock is shipping in M54, we shouldn't be seeing it at all in M53 is my understanding. So disabling it in M53 sounds right 
Agreed, since the UI in M53 does not match spec.
I'll upload a patch that disables it on M53.
Status: Started (was: Assigned)
https://codereview.chromium.org/2280633003
Labels: Merge-Request-53
Labels: -Merge-Request-53
Labels: Merge-Request-53
Merge request for m53. The patch is simple, it disables quick unlock entirely. I'm not planning on landing it in master.

If we really want to allow users to play around with quick unlock on m53, we can also back port a few patches which include a flag the user can activate. I don't think this is worthwhile though, seeing as a lot of the experience is broken according to the spec.
Labels: OS-Chrome

Comment 12 by dimu@chromium.org, Aug 27 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M53, manual review required.
Labels: -Merge-Review-53 Merge-Approved-53
Approving merge to M53 cros.
Labels: -Hotlist-Merge-review
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 30 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a9a22d779166c24ea92d7825d1bf33d1559372e

commit 5a9a22d779166c24ea92d7825d1bf33d1559372e
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Aug 30 20:51:21 2016

Disable pin unlock for m53 only.

See https://codereview.chromium.org/2280633003/.

BUG= 639977 

(cherry picked from commit c897cc67701a2f04cc4554d41a0ad39ff9bd61df)

Review URL: https://codereview.chromium.org/2289393002 .

Cr-Commit-Position: refs/branch-heads/2785@{#793}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/5a9a22d779166c24ea92d7825d1bf33d1559372e/chrome/browser/chromeos/login/quick_unlock/pin_storage.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment