New issue
Advanced search Search tips

Issue 639969 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromite/lib/*.py fails lint.

Project Member Reported by dgarr...@chromium.org, Aug 22 2016

Issue description

dgarrett$cros lint lib/*.py
************* Module chromite.lib.auto_updater
C:  1, 0: Too many blank lines in a row: offset:10: {} (docstring-too-many-newlines)
C:  1, 0: Too many blank lines in a row: offset:30: {} (docstring-too-many-newlines)
C:  1, 0: Too many blank lines in a row: offset:50: {} (docstring-too-many-newlines)
W:949, 4: No exception type(s) specified (bare-except)
************* Module chromite.lib.timeout_util
W:261,30: Access to a protected member _MainThread of a client class (protected-access)
14:53:10: ERROR: linter found errors in 2 files



Git logs show you introduced these. Can you clean them up?
 

Comment 1 by aut...@google.com, Aug 23 2016

Labels: -current-issue
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7381c2dc32165daee391e927c976bcf819831ec3

commit 7381c2dc32165daee391e927c976bcf819831ec3
Author: xixuan <xixuan@google.com>
Date: Mon Aug 22 22:21:26 2016

chromite: clear pylint warning.

BUG= chromium:639969 
TEST=None

Change-Id: I6bbcf3682eb7b4e1bdc0c5a5f93d6a27acd25294
Reviewed-on: https://chromium-review.googlesource.com/373999
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/7381c2dc32165daee391e927c976bcf819831ec3/lib/timeout_util.py
[modify] https://crrev.com/7381c2dc32165daee391e927c976bcf819831ec3/lib/auto_updater.py

Status: Fixed (was: Untriaged)

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 5 by dchan@chromium.org, Oct 10 2016

Labels: -VerifyIn-55

Comment 6 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment