"AutofillInteractiveTest.BasicFormFill" is flaky |
||||
Issue description"AutofillInteractiveTest.BasicFormFill" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMAsSBUZsYWtlIiVBdXRvZmlsbEludGVyYWN0aXZlVGVzdC5CYXNpY0Zvcm1GaWxsDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Aug 22 2016
,
Aug 22 2016
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a8aef55976f4a22a32f1ee79095f2c5a7c3ee8a commit 2a8aef55976f4a22a32f1ee79095f2c5a7c3ee8a Author: megjablon <megjablon@chromium.org> Date: Mon Aug 22 23:32:00 2016 Disable flaky AutofillInteractiveTest.BasicFormFill test Fails with error: AutofillInteractiveTest.BasicFormFill (run #1): [ RUN ] AutofillInteractiveTest.BasicFormFill [1552:1980:0818/035001:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! See https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/275933 TBR=mathp@chromium.org BUG= 639940 Review-Url: https://codereview.chromium.org/2269733002 Cr-Commit-Position: refs/heads/master@{#413581} [modify] https://crrev.com/2a8aef55976f4a22a32f1ee79095f2c5a7c3ee8a/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/522146e8024f81aff5a7c076f5a819aec719ed99 commit 522146e8024f81aff5a7c076f5a819aec719ed99 Author: Greg Thompson <grt@chromium.org> Date: Thu Oct 05 00:02:06 2017 Deflake ui_controls::SendMouseMove on Windows. On Windows, SendMouseMove must transform a point in screen coordinates into the range (0..2^16-1) for consumption by SendInput. Windows then converts this back to screen coordinates. This change rounds up rather than down in the initial conversion so that Windows lands on the correct point when it seemly truncates. Previously, we'd see off-by-one errors from time to time. While this may seem insignificant at first blush, it's problematic when SendMouseMove is called to move the mouse to a point where it already resides. No events are generated by SendInput in this case, so the hook proc will never be called. This shouldn't be a problem since SendMouseMove detects this case and short-circuits the request. With the ob1, however, SendMouseMove thinks it needs to move the mouse by one point, yet the bad math results in a call to SendInput to move the mouse to its current position. This makes tests timeout and all of us sad. BUG= 390564 , 639940 , 710436 , 726659 , 728488 , 764415 R=mathp@chromium.org, sky@chromium.org Change-Id: I1daebe8281db0a799ef7266c3c1765de65580f03 Reviewed-on: https://chromium-review.googlesource.com/686898 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#506574} [modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/autofill/autofill_interactive_uitest.cc [add] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/ui/send_mouse_move_uitest_win.cc [modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/test/BUILD.gn [modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/ui/base/test/ui_controls_internal_win.cc
,
Nov 16 2017
I believe this is no longer flaky. |
||||
►
Sign in to add a comment |
||||
Comment 1 by megjab...@chromium.org
, Aug 22 2016