Crash in DownloadUIAdapter |
||
Issue descriptionReported by dfalcantara@ Stack: 1886 00a2de11 offline_pages::DownloadUIAdapter::LoadCache() 1887 00a2dd05 offline_pages::DownloadUIAdapter::AddObserver(offline_pages::DownloadUIAdapter::Observer*) 1888 0049665b OfflinePageDownloadBridge 1889 v------> offline_pages::android::Init(_JNIEnv*, base::android::JavaParamRef<_jobject*> const&, base::android::JavaParamRef<_jo Happened as a result of https://codereview.chromium.org/2263753002/ Apparently, if the Adapter's observers are quickly added/removed/added, the DCHECK(!is_loaded) fires because the flag is set asynchronously (it should, but more accurately).
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1747c84cb590b1d7361cc8b70ff5ac3ec34ce42 commit c1747c84cb590b1d7361cc8b70ff5ac3ec34ce42 Author: dimich <dimich@chromium.org> Date: Tue Aug 23 03:27:51 2016 Fix a crash in DownloadUIAddapter that happens when Java bridge is created/removed quickly while call to async GetAllPages is still in flight. BUG= 639931 Review-Url: https://codereview.chromium.org/2264233002 Cr-Commit-Position: refs/heads/master@{#413654} [modify] https://crrev.com/c1747c84cb590b1d7361cc8b70ff5ac3ec34ce42/components/offline_pages/downloads/download_ui_adapter.cc [modify] https://crrev.com/c1747c84cb590b1d7361cc8b70ff5ac3ec34ce42/components/offline_pages/downloads/download_ui_adapter.h [modify] https://crrev.com/c1747c84cb590b1d7361cc8b70ff5ac3ec34ce42/components/offline_pages/downloads/download_ui_adapter_unittest.cc
,
Aug 23 2016
Please keep open, I need to clean up one more thing for this bug.
,
Aug 26 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dim...@chromium.org
, Aug 22 2016