Issue metadata
Sign in to add a comment
|
Pressing <Esc> to dismiss any permission request bubble makes it reappear again after tab switch.
Reported by
miklos.j...@a8c.com,
Aug 22 2016
|
||||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Steps to reproduce the problem: 1. Launch Chrome and visit https://jsbin.com/mayamamohi/edit?html,js,output 2. Open the Console from developer tools 3. Hit Request Permission, and press Escape to close the bubble 4. Observe that the Request Permission button remains disabled implying that the `Notification.requestPermission()` Promise has not resolved yet, but the bubble disappears. There is nothing logged to the console. 5. Switch to a new tab and back. Observe that the bubble is visible again. Video: https://cldup.com/7Hf3YL97Xs.gif What is the expected behavior? Expected behavior is the same as how the 'x' button press behaves: 1. Launch Chrome and visit https://jsbin.com/mayamamohi/edit?html,js,output 2. Open the Console from developer tools 3. Hit Request Permission. Observe that the Request Permission button get disabled. 4. Click on the 'x' to close the bubble. Observe that the 'The permission request was dismissed.' line is logged to the console. The Request Permission button is enabled again. What went wrong? Hitting Escape to close the permission bubble leaves the UI in a broken state, and after switching to a new tab and back the permission bubble is visible again so Escape does not fully close it. Some sites that use notifications and are broken because of this issue: Facebook: https://cloudup.com/ieFDscA85jz Googe Drive: https://cloudup.com/iCwx7E4lfAx Twitter: https://cloudup.com/iKpnNuevOlW WordPress.com: https://cloudup.com/iIyXko7l8Pl Did this work before? Yes Chrome 50 still worked as expected, Chrome 51 and up (until 54 at the moment) does not work anymore. Chrome version: 52.0.2743.116 Channel: stable OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 22.0 r0
,
Aug 23 2016
Would either of you two know about this? Feel free to un-CC yourselves if not :) I've checked whether this happens in Linux and MacViews and it doesn't for both.
,
Aug 23 2016
From the bug report, it seems that this is a regression. A bisect should help.
,
Aug 24 2016
I think Mac permission bubbles and ESC is horribly broken. See issue 385088 for some sordid details. Maybe we should up this bug into that one...
,
Aug 24 2016
As per comment #3 tried bisecting this issue but unable to find any regression range. In the original comment user mentioned saying this issue was not there on chrome M50 builds. So tested the same on M50-50.0.2624.0 but issue is still seen over there. Other than M50 tried testing on M40, M45 builds as well observed a different bubble appears bottom to the omnibox while clicking on the close button the request permission button is getting disabled. Note: Attaching screen-cast for reference, please have a look on it. Thanks!
,
Aug 24 2016
,
Aug 24 2016
This is not a duplicate of the other bug. They are related, but concerned with different aspects of ESC
,
Nov 3 2016
,
Dec 13 2016
I think I fixed this as of https://codereview.chromium.org/2403763003 |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by patricia...@chromium.org
, Aug 23 2016Status: Untriaged (was: Unconfirmed)
Summary: Pressing <Esc> to dismiss any permission request bubble makes it reappear again after tab switch. (was: Pressing escape in Notification permission bubble does not return the default state but closes the bubble only)