Composited scrolling contents layer not invalidated when local background is removed. |
|||||
Issue descriptionIn the attached test a composited scroller has a local background (which is painted into the scrolling contents layer). When this background is removed the scrolling contents layer needs to be invalidated in order to clear the background. We need to correctly tell that the background used to be painted onto the scrolling contents layer.
,
Aug 22 2016
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f4aaf6e67cb051586ab6f028bfed6411b1893a3 commit 7f4aaf6e67cb051586ab6f028bfed6411b1893a3 Author: flackr <flackr@chromium.org> Date: Thu Aug 25 22:55:12 2016 Repaint when background switches painting from/to scrolling contents layer. BUG= 639886 TEST=paint/invalidation/composited-overflow-local-background-removed.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2266103002 Cr-Commit-Position: refs/heads/master@{#414571} [add] https://crrev.com/7f4aaf6e67cb051586ab6f028bfed6411b1893a3/third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-local-background-removed-expected.html [add] https://crrev.com/7f4aaf6e67cb051586ab6f028bfed6411b1893a3/third_party/WebKit/LayoutTests/paint/invalidation/composited-overflow-local-background-removed.html [modify] https://crrev.com/7f4aaf6e67cb051586ab6f028bfed6411b1893a3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp [modify] https://crrev.com/7f4aaf6e67cb051586ab6f028bfed6411b1893a3/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h [modify] https://crrev.com/7f4aaf6e67cb051586ab6f028bfed6411b1893a3/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
,
Aug 30 2016
Tested this issue on Mac OS 10.11.6 and Windows-10 using chrome latest Dev M54-54.0.2840.0. By opening the test-bg.html file, Observed an empty scrolling content with scroll bar where able to scroll it without any issue but able to see a red screen flashing at the time of refreshing the page. flackr@ - Could you please confirm is this is the right way to verify this issue? or is there any other manual repro steps to verify this issue from Chrome-TE end. Thanks!
,
Aug 30 2016
Correct, the error was that the red did not go away before the fix.
,
Aug 30 2016
As per comment #5 it's confirmed the issue got fixed on latest Dev, Hence adding TE-Verified label.
,
Aug 30 2016
Status should be verified as well I assume. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by flackr@chromium.org
, Aug 22 2016Components: Blink>Paint>Invalidation