New issue
Advanced search Search tips

Issue 639883 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Clean up PointerWatcherDelegate

Project Member Reported by jamescook@chromium.org, Aug 22 2016

Issue description

Now that sysui is gone the only implementation is PointerWatcherDelegateAura, so call directly into that.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a9d02e415ae8da70750a964aaa7bb393ad2612c

commit 0a9d02e415ae8da70750a964aaa7bb393ad2612c
Author: jamescook <jamescook@chromium.org>
Date: Tue Aug 23 00:20:05 2016

ash: Eliminate PointerWatcherDelegate

Now that ash_sysui is unused the aura implementation is the only one and
we don't need a delegate.

* Remove CreatePointerWatcherDelegate() from ShellDelegate
* Rename PointerWatcherDelegateAura to PointerWatcherAdapter
* Call directly into PointerWatcherAdapter from WmShellAura and eliminate
ash::Shell::AddPointerWatcher
* Delete ash/sysui/pointer_watcher_delegate_mus.*

No behavior changes.

BUG= 639883 
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2267023003
Cr-Commit-Position: refs/heads/master@{#413599}

[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/ash.gyp
[rename] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/aura/pointer_watcher_adapter.cc
[rename] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/aura/pointer_watcher_adapter.h
[rename] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/aura/pointer_watcher_adapter_unittest.cc
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/aura/wm_shell_aura.h
[delete] https://crrev.com/4b7a2c96534b896b3fb59c8afc93df70e62ae3b1/ash/common/pointer_watcher_delegate.h
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/common/shell_delegate.h
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/shell.cc
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/shell.h
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/sysui/BUILD.gn
[delete] https://crrev.com/4b7a2c96534b896b3fb59c8afc93df70e62ae3b1/ash/sysui/pointer_watcher_delegate_mus.cc
[delete] https://crrev.com/4b7a2c96534b896b3fb59c8afc93df70e62ae3b1/ash/sysui/pointer_watcher_delegate_mus.h
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/ash/test/test_shell_delegate.h
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c/chrome/browser/ui/ash/chrome_shell_delegate.h

Status: Fixed (was: Started)
Labels: VerifyIn-54
bulk verified
Status: Verified (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment