New issue
Advanced search Search tips

Issue 639882 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Do component builds for ozone in FYI mojo-chromeos builder

Project Member Reported by sadrul@chromium.org, Aug 22 2016

Issue description

This builder: https://build.chromium.org/p/chromium.fyi/builders/Mojo%20ChromiumOS

The current config used:

ffmpeg_branding = "ChromeOS"
goma_dir = "/b/c/cipd/goma"
is_component_build = false
is_debug = false
proprietary_codecs = true
target_os = "chromeos"
use_goma = true

What we should use instead:

ffmpeg_branding = "ChromeOS"
goma_dir = "/b/c/cipd/goma"
is_component_build = true
is_debug = false
dcheck_always_on = true
proprietary_codecs = true
target_os = "chromeos"
use_goma = true
use_ozone = true

This is essentially the same config as the regular ozone-chroemos builder (https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng), except for the 'is_component_build' set to true.

This would allow us to start running mash_browser_tests on ozone builds. We cannot use the regular builder right now, since there are issues with tcmalloc in non-component builds.
 

Comment 1 by sadrul@chromium.org, Aug 22 2016

See issues  594674  and  639039  for some details about tcmalloc issue.
Cc: kylec...@chromium.org

Comment 3 by msw@chromium.org, Aug 22 2016

Cc: dpranke@chromium.org
Owner: msw@chromium.org
Status: Started (was: Available)
Here's a wip bot config change: https://codereview.chromium.org/2261303002/
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10fa24d67b3d7cca19c634a94fe027c5d8692169

commit 10fa24d67b3d7cca19c634a94fe027c5d8692169
Author: msw <msw@chromium.org>
Date: Tue Aug 23 22:50:06 2016

mash: Update Mojo ChromiumOS fyi bot config.

Make the Mojo ChromiumOS fyi bot shared/ozone/dcheck.

BUG= 639882 
TEST=Config matches that requested on the bug.
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2261303002
Cr-Commit-Position: refs/heads/master@{#413876}

[modify] https://crrev.com/10fa24d67b3d7cca19c634a94fe027c5d8692169/tools/mb/mb_config.pyl

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a17c267c6a457d280a75e8cd39aa39d6adcb58f3

commit a17c267c6a457d280a75e8cd39aa39d6adcb58f3
Author: msw <msw@chromium.org>
Date: Tue Aug 30 21:58:40 2016

Make the Mojo ChromiumOS fyi bot release+dcheck.

We used debug (component builds) to workaround  Issue 594674 .
Scott recently fixed mash browser tests for static builds with:
  https://codereview.chromium.org/2295433003/

Make the bot release again, but now with ozone+dchecks.
It's TBD if we need more args to make mash work with ozone:
 ozone_auto_platforms = false
 ozone_platform_x11 = true

BUG= 639882 , 642433 
TEST=Mojo ChromiumOS fyi bot does release+dcheck builds.
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2291013003
Cr-Commit-Position: refs/heads/master@{#415448}

[modify] https://crrev.com/a17c267c6a457d280a75e8cd39aa39d6adcb58f3/tools/mb/mb_config.pyl

Comment 6 by msw@chromium.org, Aug 30 2016

Status: Fixed (was: Started)
I'm going to mark this fixed.  Issue 642433  tracks problems with ozone flags.
Components: -MUS Internals>Services>WindowService

Sign in to add a comment