New issue
Advanced search Search tips

Issue 639873 link

Starred by 3 users
Status: Fixed
Owner:
r...@igalia.com
Closed: May 2017
Cc:
jfernan...@igalia.com
r...@igalia.com
svil...@igalia.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 273898



Sign in to add a comment

[css-grid] Incorrect rendering of absolute items with vertical writing modes

Project Member Reported by svil...@igalia.com, Aug 22 2016 
I'm attaching a simple test case which should render 2 absolute positioned items with a height exactly matching the height of each row. Instead we get a single one spanning the whole height of the grid (even the padding).
ein.html
904 bytes View Download

Comment 1 by svil...@igalia.com, Aug 22 2016 

Adding Blink and FF's rendering (FF does it right) just to be clear about the expected results
rendering.png
12.8 KB View Download

Comment 2 by r...@igalia.com, Aug 23 2016

Blocking: 273898
Cc: svil...@igalia.com
Components: Blink>Layout>Grid
Status: Available (was: Untriaged)
Yeah, it's easily reproducible with any abspos grid item with a vertical writing mode.

Comment 3 by r...@igalia.com, Aug 23 2016 

Actually it's expected they don't work at this point.
You can see the following FIXME in LayoutGrid::layoutPositionedObjects():
    for (auto* child : *positionedDescendants) {
        if (isOrthogonalChild(*child)) {
            // FIXME: Properly support orthogonal writing mode.
            continue;
        }
Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f04178ffc2984344d254363261c8dc9a38265de

commit 1f04178ffc2984344d254363261c8dc9a38265de
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Wed May 24 17:25:38 2017

[css-grid] Add support for orthogonal positioned grid items

This patch adds support for positioned grid items with orthogonal flows.
Basically it just needs to check if the item is orthogonal to use
the column or row offset as logical left or top depending on the case.

Added new tests for WPT repository under: css/css-grid-1/abspos/
Two of these new tests are failing due to an issue with margins
and orthogonal items, which is unrelated to this patch (see  bug #725903 ).

BUG= 639873 

Change-Id: Ic6aef9eef46a8a254678aac8958f0976cb53e89c
Reviewed-on: https://chromium-review.googlesource.com/513965
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#474335}
[modify] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-001-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-001.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-002.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-003.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-004.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-005-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-005.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-006-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-006.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-007-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-007.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-008-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-008.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-009-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-009.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-010.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-011-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-011.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-012-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-012.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-013-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-013.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-014-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-014.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-015-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-015.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-016-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-016.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-017-ref.html
[add] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/abspos/orthogonal-positioned-grid-items-017.html
[modify] https://crrev.com/1f04178ffc2984344d254363261c8dc9a38265de/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Comment 5 by r...@igalia.com, May 24 2017

Owner: r...@igalia.com
Status: Fixed (was: Available)
►

Sign in to add a comment